Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard returning 200 status on error #95

Open
matthewandrews opened this issue Nov 1, 2018 · 1 comment
Open

dashboard returning 200 status on error #95

matthewandrews opened this issue Nov 1, 2018 · 1 comment

Comments

@matthewandrews
Copy link
Member

When the dashboard has a Grails runtime exception (e.g. just now due to #94), it is returning a 200 HTTP status code, meaning our external monitoring does not recognise a problem.

@nickdos
Copy link
Contributor

nickdos commented Nov 2, 2018

I had a quick look at this but it wasn't trivial, so left it for now. Getting dashboard working was a higher priority due to #94 bug.

NTS: problem is the homepage (index.gsp) is GSP only (no controller code) and everything is loaded via JSON or GSP includes (with their own controller methods). There is already a controller method for index which is tied to a JSON response, which is quite confusing. So this needs to be refactored to a different method/path and a controller method created for the main index.gsp page. I was wrong it is the same method for the GSP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants