Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent CSV escape/quoting in files produced by ExportFromIndexStream #237

Open
ansell opened this issue Dec 21, 2017 · 0 comments
Open

Comments

@ansell
Copy link
Contributor

ansell commented Dec 21, 2017

There is inconsistent CSV escape/quoting in files created by ExportFromIndexStream. Some files created by it require manually setting the non-RFC4180 escape character to \ while other require it to explicitly not set, or line size errors are artificially created. Reviewing the code, there are some calls to one constructor for CSVWriter that specifies the \ explicitly, indicating it was intentionally chosen by a biocache-store committer. However, others use the other constructor where those arguments are implicitly set, which in at least some opencsv versions is the RFC4180 quote character ".

A simple solution to this issue would be to switch all CSV writing and parsing to RFC4180, with no escape character, and just relying on the quote character.

Some background on the historical inconsistencies that are kept inside of OpenCSV for "backwards-compatibility" reasons at https://sourceforge.net/p/opencsv/support-requests/50/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants