Updates for image service 3 #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sbearcsiro
commented
Jun 24, 2024
- Add support for datadog jmx to exec jar roles
- Fix datadog sql role for non local database
- Remove using the CMS collector by default and replace with jvm extra params for clients if required
- Fix data dog sql user for non local postgres
yasima-csiro
approved these changes
Jul 12, 2024
|
looks good, I think thats better to inject the tracer and params into the JVM options in the exec-jar role, the datadog_apm role is a bit of a hack. Could there be some other services that are still using the datadog_apm role and also using exec-jar? That could cause problems. I'll look into what else is using it, the old role should be removed, also the vars that were used in it can be cleaned up https://github.com/AtlasOfLivingAustralia/ansible-inventories/blob/master/image-service/image-service-test-cognito.yml#L171-L176 |
joe-lipson
approved these changes
Jul 12, 2024
brucehyslop
added a commit
that referenced
this pull request
Aug 29, 2024
…a-install * 'master' of https://github.com/AtlasOfLivingAustralia/ala-install: Update geoserver to 2.25.2. Fix #821 add hubs dataResourceUuid.* to config Updates for image service 3 (#813) Add digivol/internal scope (#806) add bie and biocache hub challenge js config (#817) add biocache-hub variable downloads_fieldguide_species_max Enable AWS SES in Alerts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.