Fix prompting login for public pages issue #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-collins
requested changes
Mar 25, 2024
| @@ -16,7 +16,7 @@ security.cas.uriFilterPattern={{ collectory_uri_filter_pattern | default('/admin | |||
| security.cas.uriFilterPattern={{ collectory_uri_filter_pattern | default('/admin,/admin/*,/collection/*,/institution/*,/contact/*,/reports/*,/providerCode/*,/providerMap/*,/dataProvider/*,/dataResource/*,/dataHub/*,/manage/*,/alaAdmin,/alaAdmin/*,/ws/ipt/scan/*') }} | |||
| {% endif %} | |||
|
|
|||
| security.cas.authenticateOnlyIfLoggedInFilterPattern={{ collectory_authenticate_only_if_logged_in_filter_pattern | default('/public/show/*') }} | |||
| security.cas.authenticateOnlyIfLoggedInFilterPattern={{ collectory_authenticate_only_if_logged_in_filter_pattern | default('') }} | |||
There was a problem hiding this comment.
The removal of /public/show/* breaks the functionality of this page. There is role conditional content and without this pattern it breaks the login button that would otherwise be required to make it work.
| @@ -14,7 +14,7 @@ security.cas.casServerLogoutUrl={{ auth_base_url }}/cas/logout | |||
| security.cas.loginUrl={{ auth_base_url }}/cas/login | |||
| security.cas.logoutUrl={{ auth_base_url }}/cas/logout | |||
| security.cas.uriFilterPattern={{ biocache_hub_uri_filter_pattern | default('/admin/*,/alaAdmin/*,/download/*') }} | |||
| security.cas.authenticateOnlyIfLoggedInFilterPattern={{ biocache_hub_authenticate_only_if_logged_in_filter_pattern | default('/occurrences/*,/explore/your-area,/query,/proxy/download/*,/') }} | |||
| security.cas.authenticateOnlyIfLoggedInFilterPattern={{ biocache_hub_authenticate_only_if_logged_in_filter_pattern | default('/query,/proxy/download/*') }} | |||
There was a problem hiding this comment.
The removal of /occurrences/* breaks the role conditional content of occurrence pages, i.e. club view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for AtlasOfLivingAustralia/ala-bie-hub#117