Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing descriptions of code statuses #146

Open
Xerphis opened this issue Mar 23, 2021 · 0 comments
Open

Missing descriptions of code statuses #146

Xerphis opened this issue Mar 23, 2021 · 0 comments

Comments

@Xerphis
Copy link

Xerphis commented Mar 23, 2021

Undefined offset: 422 in ...athlon1600\php-proxy\src\Http\Response.php on line 77

In Response class, in status codes missing some of descriptions from status codes. For example: 422 - but there are more codes without description. If index (status code) not exists, php throw notice message. Other descriptions that should be completed can be found here.

Moreover, code descriptions should first come from the original http response, and as a last resort, if the description from the response does empty, it should be overwritten with the description from $statusCodes. Otherwise, if the index in $statusCodes is not found, the method getStatusText should return an default value (empty string).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant