-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test code coverage #502
Test code coverage #502
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #502 +/- ##
==========================================
- Coverage 66.66% 0.00% -66.67%
==========================================
Files 17 11 -6
Lines 2049 1619 -430
Branches 0 158 +158
==========================================
- Hits 1366 0 -1366
- Misses 683 1619 +936
Flags with carried forward coverage won't be shown. Click here to find out more. see 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #502 +/- ##
=======================================
Coverage 52.00% 52.00%
=======================================
Files 17 17
Lines 2096 2096
Branches 166 166
=======================================
Hits 1090 1090
Misses 934 934
Partials 72 72 ☔ View full report in Codecov by Sentry. |
After resetting Codecov, with one unit test the reported coverage is 3.16%, with 100% coverage in the |
Adding one model test increases coverage to 39.38% with 100% coverage in the |
With another unit test, total coverage increases to 41.40%. |
Adding all unit tests increases total coverage to 50.93%, and with the known solutions model tests to 51.31% |
aadfae6
to
6ff6870
Compare
@spco @JamesAllsopp I think this is working (see my notes above). Total coverage is now 52%, which is lower than it was, but I think this reflects the fact that it is now calculated properly. Any comments before I merge? (can one of you approve the PR, when you have a minute? thanks). @JamesAllsopp Can you check you are happy with the acknowledgements in the |
This is simply to test that code coverage works as intended. (First need to merge PR #501).