Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test code coverage #502

Merged
merged 33 commits into from
Sep 12, 2023
Merged

Test code coverage #502

merged 33 commits into from
Sep 12, 2023

Conversation

rs028
Copy link
Collaborator

@rs028 rs028 commented Sep 4, 2023

This is simply to test that code coverage works as intended. (First need to merge PR #501).

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #502 (21c51da) into master (87e02fd) will decrease coverage by 66.67%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #502       +/-   ##
==========================================
- Coverage   66.66%   0.00%   -66.67%     
==========================================
  Files          17      11        -6     
  Lines        2049    1619      -430     
  Branches        0     158      +158     
==========================================
- Hits         1366       0     -1366     
- Misses        683    1619      +936     
Flag Coverage Δ
build ?
tests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e02fd...21c51da. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e62c2c1) 52.00% compared to head (65ec392) 52.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   52.00%   52.00%           
=======================================
  Files          17       17           
  Lines        2096     2096           
  Branches      166      166           
=======================================
  Hits         1090     1090           
  Misses        934      934           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rs028
Copy link
Collaborator Author

rs028 commented Sep 5, 2023

After resetting Codecov, with one unit test the reported coverage is 3.16%, with 100% coverage in the tests/unit_tests/ directory and 1.12% in the src/ directory (correctly identifies the argparse.f90 as affected by the tests).

@rs028
Copy link
Collaborator Author

rs028 commented Sep 5, 2023

Adding one model test increases coverage to 39.38% with 100% coverage in the tests/unit_tests/ directory and 38.22% in the src/ directory.

@rs028
Copy link
Collaborator Author

rs028 commented Sep 5, 2023

With another unit test, total coverage increases to 41.40%.
In particular, coverage of src/atmosphereFunctions.f90 goes from 29.63% to 61.54%.

@rs028
Copy link
Collaborator Author

rs028 commented Sep 6, 2023

Adding all unit tests increases total coverage to 50.93%, and with the known solutions model tests to 51.31%

@rs028
Copy link
Collaborator Author

rs028 commented Sep 6, 2023

@spco @JamesAllsopp I think this is working (see my notes above). Total coverage is now 52%, which is lower than it was, but I think this reflects the fact that it is now calculated properly. Any comments before I merge? (can one of you approve the PR, when you have a minute? thanks).

@JamesAllsopp Can you check you are happy with the acknowledgements in the Credits.tex file?

@rs028 rs028 merged commit 4373dc9 into AtChem:master Sep 12, 2023
8 checks passed
@rs028 rs028 deleted the test_code_coverage branch September 12, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants