Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stylesheet): make everything more consistent #23

Merged
merged 3 commits into from
Aug 13, 2021
Merged

refactor(stylesheet): make everything more consistent #23

merged 3 commits into from
Aug 13, 2021

Conversation

Gitleptune
Copy link
Contributor

@Gitleptune Gitleptune commented Aug 13, 2021

changes:

  • spaces after all colons (: )
  • replace white & black with #fff and #000 (shorter)
  • remove empty lines where they aren't needed
  • add more comments; have comments always start with a capital letter

@ArthurSonzogni
Copy link
Owner

ArthurSonzogni commented Aug 13, 2021

Thanks!

I like the changes:

  • spaces after all colons (: )
  • add more comments; have comments always start with a capital letter

but I would prefer not to have:

  • remove empty lines where they aren't needed
  • replace white & black with #fff and #000 (shorter)

Copy link
Owner

@ArthurSonzogni ArthurSonzogni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This looks good to me % one comment below:

src/style.css Outdated
Comment on lines 150 to 153
+0px 0px 15px var(--bg-color),
+0px -15px 20px rgba(255,0,0,0.5),
-15px +10px 20px rgba(0,255,0,0.5),
+10px +15px 20px rgba(0,0,255,0.5);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you reverse this change? It looks like you used indentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I indented it like that so the px is on the same column but I'll fix it in a sec 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also shouldn't this have some transition property because it's a :hover element? I have to hover for a few seconds before it shows up, very cool effect though.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transition is:

  transition: text-shadow 1s ease-in-out 1s;

So, we wait for 1 second before triggering the transition. This was done on purpose to make this a bit harder to find. This is a sort of easter eggs.

@ArthurSonzogni ArthurSonzogni merged commit 3032fca into ArthurSonzogni:master Aug 13, 2021
@ArthurSonzogni
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants