cleanup quorum configuration

[robfrank]

What does this PR do?

just a cleanup and small refactoring of HA quorum configuration

Motivation

Improve readability

Checklist

• I have run the build using mvn clean package command
• My unit tests cover both failure and success scenarios

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.07%	✅ 53.85%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (421e4f5)	68100	43611	64.04%
Head commit (1c64ec0)	68092 (-8)	43652 (+41)	64.11% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1833)	13	7	53.85%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[lvca]

Shouldn't we have the default here that throws an exception like with the original code?

[robfrank]

No, this is the "trick" of using the Enum itself. You can only call the method if you are using one of the Enuma: QUORUM. ONE/TWO/THREE/MAJORITY/ALL.

The parsing of the value from the conf is in ReplicatedDatabase line 100.

No more need for exception