Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Mobile editor toolbar height issue #5573

Open
q200892907 opened this issue Jun 19, 2024 · 9 comments
Open

[Bug] Mobile editor toolbar height issue #5573

q200892907 opened this issue Jun 19, 2024 · 9 comments

Comments

@q200892907
Copy link
Contributor

Bug Description

Mobile editor toolbar height issue

How to Reproduce

Huawei mate40 pro

Expected Behavior

Toolbar position is normal

Operating System

mobile

AppFlowy Version(s)

main

Screenshots

WechatIMG8

Additional Context

No response

@q200892907
Copy link
Contributor Author

final height = MediaQuery.of(context).viewInsets.bottom;
Consider using it in combination
@LucasXu0

@LucasXu0
Copy link
Collaborator

Screenshot 2024-06-19 at 16 55 46

@q200892907 I have added the keyboard height to viewPadding.bottom. Does it not work?

@q200892907
Copy link
Contributor Author

截图 2024-06-19 16 55 46 @q200892907我已将键盘高度添加到 viewPadding.bottom。这不起作用吗?

@LucasXu0 Didn't work

@q200892907
Copy link
Contributor Author

keyboard_height_plugin:
git: https://github.com/q200892907/keyboard_height_plugin.git
I forked the plugin and modified it, and it works on the phone with the problem

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Jun 19, 2024

I noticed that you submitted a PR to the official repo already. If it's merged, you can submit a PR to upgrade the keyboard_height_plugin dependency.

@q200892907
Copy link
Contributor Author

我注意到您已经向官方仓库提交了 PR。如果已合并,您可以提交 PR 来升级keyboard_height_plugin依赖项。

OK, I will follow the information of keyboard_height_plugin

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Jul 5, 2024

@q200892907 Could you confirm that your PR has fixed the blocking toolbar issue?

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Jul 5, 2024

I tried your PR. The API still doesn't return the correct keyboard height. You can check my screenshot.

Screenshot 2024-07-05 at 10 56 03

@q200892907
Copy link
Contributor Author

@LucasXu0 Xiaomi, Huawei, I can test the hand with the bottom toolbar of the phone test no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants