Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote DNS resolution bug when using create_connection #25

Closed
six-pack opened this issue May 6, 2015 · 1 comment
Closed

Remote DNS resolution bug when using create_connection #25

six-pack opened this issue May 6, 2015 · 1 comment

Comments

@six-pack
Copy link

six-pack commented May 6, 2015

The call to sock.set_proxy inside create_connection fails to correctly pass the rdns parameter. The result is that remote dns resolution is not performed.

A workaround is to set the username to True (because the username is sent where rdns should be)

if proxy_type is not None:
    sock.set_proxy(proxy_type, proxy_addr, proxy_port,
                   proxy_username, proxy_password)

should be

if proxy_type is not None:
    sock.set_proxy(proxy_type, proxy_addr, proxy_port, rdns
                   proxy_username, proxy_password)
@Anorov Anorov closed this as completed in ddf5076 May 6, 2015
@six-pack
Copy link
Author

six-pack commented May 6, 2015

Good work, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant