Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Style the theme switcher with custom icons #69

Open
1 of 2 tasks
monacodelisa opened this issue May 2, 2024 · 4 comments
Open
1 of 2 tasks

Feature: Style the theme switcher with custom icons #69

monacodelisa opened this issue May 2, 2024 · 4 comments

Comments

@monacodelisa
Copy link
Member

Type of feature

✨ Feature

Current behavior

Native primeng input switch

Suggested solution

Try to make it like - TechOpenSolve.com

  • add custom icons inside the theme switch

Additional context

No response

I would be willing to submit a PR to fix this issue

Copy link

github-actions bot commented May 2, 2024

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@MestiriBaha
Copy link
Contributor

I was searching and I tried to add icons inside the slider of PrimeNG p-inputSwitch , However, it proved to be quite challenging , I searched on Stack Overflow and checked the documentation, but I don't think anyone has tried it using the Native primeng input switch , So, I began trying to figure out how to create a custom input switch, but I'm not sure if that's the right approach. Do you have any ideas on how to achieve this?

@monacodelisa
Copy link
Member Author

monacodelisa commented May 11, 2024

@MestiriBaha its's cool that you were looking into it :)
If you have a look at the Assignees section you can see that I have myself assigned to the issue

image

When you see someone assigned on an issue - that means that they are working on it.
Typically while there is an assignee the issue is not available for others.

I have already implemented my custom theme-switcher on numerous apps, and I should be implementing it soon
but I am working on other projects currently.

I am not surprised that you are not finding tutorials about it, it is a custom theme-switcher that I started working on and I just liked it and have been implementing it on my apps all over :)

If you do want to work on it -> generally there are 2 ways to go about it:

  • Renderer 2 & custom directive
  • vanilla JS way

I have done the vanilla JS way, you are welcome to continue exploring, since I am not going to be available to implement it in the next couple of weeks. If you get it done, just submit a PR, and then we can review it and improve or merge :)

Don't worry if you don't get a progress -> I do intend to implement it eventually and I can tag you so you can see the changes

@MestiriBaha
Copy link
Contributor

Thank you for clearing that up ! Honestly, I did notice the assignees section, but somehow it slipped my mind, haha! I'll definitely give the theme switcher a shot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants