-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Style the theme switcher with custom icons #69
Comments
Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label. To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself. For full info on how to contribute, please check out our contributors guide. |
I was searching and I tried to add icons inside the slider of PrimeNG |
@MestiriBaha its's cool that you were looking into it :) When you see someone assigned on an issue - that means that they are working on it. I have already implemented my custom theme-switcher on numerous apps, and I should be implementing it soon I am not surprised that you are not finding tutorials about it, it is a custom theme-switcher that I started working on and I just liked it and have been implementing it on my apps all over :) If you do want to work on it -> generally there are 2 ways to go about it:
I have done the vanilla JS way, you are welcome to continue exploring, since I am not going to be available to implement it in the next couple of weeks. If you get it done, just submit a PR, and then we can review it and improve or merge :) Don't worry if you don't get a progress -> I do intend to implement it eventually and I can tag you so you can see the changes |
Thank you for clearing that up ! Honestly, I did notice the assignees section, but somehow it slipped my mind, haha! I'll definitely give the theme switcher a shot |
Type of feature
✨ Feature
Current behavior
Native primeng input switch
Suggested solution
Try to make it like - TechOpenSolve.com
Additional context
No response
I would be willing to submit a PR to fix this issue
The text was updated successfully, but these errors were encountered: