Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: settings dialog opens another instance of itself on close on mobile #54

Open
1 of 2 tasks
monacodelisa opened this issue Mar 22, 2024 · 3 comments
Open
1 of 2 tasks
Labels
🐛 bug Something isn't working 👀 needs triage

Comments

@monacodelisa
Copy link
Member

Describe the bug

While working on initial sitewide responsiveness, and making adjustments to the dialogs,
I saw that when I close the settings dialog it immediately creates another instance of itself which
is also not aligned well.

  • chrome simulator
  • mobile device

Steps to reproduce

  1. View either posts or series
  2. click on the gear icon to open up the settings dialog
  3. close the settings dialog
  4. observe the new one appearing

image

Browsers

Chrome

Additional context (Is this in dev or production?)

No response

I would be willing to submit a PR to fix this issue

@monacodelisa monacodelisa added 🐛 bug Something isn't working 👀 needs triage labels Mar 22, 2024
Copy link

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@MestiriBaha
Copy link
Contributor

I've been trying to resolve this bug, trying many approaches. Even after inspecting and debugging the code, I'm still not convinced of the cause of this abnormal behavior. It's so weird that this issue only occurs in the mobile version! It could be due to the media query styles of the mobile version , What do you think might be causing this tricky bug ?

@monacodelisa
Copy link
Member Author

@MestiriBaha yes this is a very peculiar issue indeed. It happens only on mobile which is the first odd thing, but also - it is the only modal that does that, there are more modals in the app and as far as i remember the rest did not have this behavior 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 👀 needs triage
Projects
None yet
Development

No branches or pull requests

2 participants