Internal support for mongodb #382
Replies: 5 comments 1 reply
-
https://github.com/Androz2091/discord-giveaways/tree/master/examples/custom-databases |
Beta Was this translation helpful? Give feedback.
-
you should add it as a builtin option |
Beta Was this translation helpful? Give feedback.
-
... I already told you arguments against it, but talk to Androz if you're that convinced of it EDIT:
PRO argument: we could make sure that the dbs work as they should=user cant make too many mistakes But thats just my opinion. |
Beta Was this translation helpful? Give feedback.
-
thats what i mean kek |
Beta Was this translation helpful? Give feedback.
-
in my opinion, adding mongodb or any other database internally to this package would be a bad idea. Today, you are saying "mongodb", tomorrow someone else will ask for "postgres", then x and y and it continues. It will make the package heavy and will require maintainers to keep it up to date with database clients just for "discord giveaways" storage. There are several examples already on this https://github.com/Androz2091/discord-giveaways/tree/master/examples/custom-databases which shows how to use discord-giveaways Maybe you have points like Current implementation is the best one. You have the freedom of choice, use whatever you prefer with this package. |
Beta Was this translation helpful? Give feedback.
-
Maybe add mongodb as a storage option. It will be really good
Beta Was this translation helpful? Give feedback.
All reactions