Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think we shouldn't use rebase for branches #127

Open
tehKaiN opened this issue Jul 25, 2020 · 0 comments
Open

I think we shouldn't use rebase for branches #127

tehKaiN opened this issue Jul 25, 2020 · 0 comments
Assignees
Labels

Comments

@tehKaiN
Copy link
Member

tehKaiN commented Jul 25, 2020

Since ACE is mostly included to projects as submodules, I think it's not reasonable since old commits may have broken references to proper submodule commits.

I've linked ACE's submodule ptplayer branch in the past as I was working on it while developing Germz. Now that I've repeatedly rebased it, submodule references are broken in old commits.

I think it's better to just merge branches with master to sync them up. This way, it's less destructive for projects which use experimental / unstable features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants