Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IResource.OnStopAsync never called #93

Open
aviadmini opened this issue Jul 4, 2019 · 3 comments
Open

IResource.OnStopAsync never called #93

aviadmini opened this issue Jul 4, 2019 · 3 comments

Comments

@aviadmini
Copy link

Is that by design?

@aviadmini aviadmini changed the title OnStopAsync never called IResource.OnStopAsync never called Jul 4, 2019
@Micky5991
Copy link
Member

Micky5991 commented Jul 4, 2019

The current situation is, that RageMP does not clean up plugins correctly. We are listening to those events, but if they do not get called, we are unable to trigger all IResource.OnStopAsync methods.

@aviadmini
Copy link
Author

I didn't find any invocation of that method in library code

@Micky5991
Copy link
Member

Yeah, thats correct, but the method, that would invocate this event, is not even called in the first place. So implementing it would not fix that problem.

The RageMP Server needs to call this method:

https://github.com/AlternateLife/ragemp-c-sdk/blob/33bcc526c842d7834f272962059778981bb300be/src/plugin.cpp#L45-L51

But the log messages do not even appear we just included that method for future compatibility. But I could try to create a workaround for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants