Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce com.almasb.fxgl.app.scene.ViewPort#bindToFit #1036

Closed
phi-whiterabbit opened this issue Apr 30, 2021 · 1 comment
Closed

Reintroduce com.almasb.fxgl.app.scene.ViewPort#bindToFit #1036

phi-whiterabbit opened this issue Apr 30, 2021 · 1 comment
Assignees
@AlmasB
Labels
type:new feature Adding a feature that isn't currently present

Comments

@phi-whiterabbit
Copy link

phi-whiterabbit commented Apr 30, 2021 •
edited
Loading

In FXGL 0.5.4 the class com.almasb.fxgl.app.scene.ViewPort had a method bindToFit. This method is commented out in the current version of FXGL.
This feature request is about to introduce that method again in the more recent versions of FXGL.
@phi-whiterabbit phi-whiterabbit added the type:new feature Adding a feature that isn't currently present label Apr 30, 2021
@phi-whiterabbit
Copy link
Author

I would submit a pull request, but i am completely unfamiliar with kotlin, so i am afraid i cannot do that.

@AlmasB AlmasB self-assigned this May 21, 2021
@AlmasB AlmasB closed this as completed in 621cbd7 Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlmasB AlmasB

Labels
type:new feature Adding a feature that isn't currently present
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlmasB @phi-whiterabbit