Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hapi v17 Support #3

Closed
3 tasks done
timcosta opened this issue Oct 24, 2017 · 5 comments
Closed
3 tasks done

Hapi v17 Support #3

timcosta opened this issue Oct 24, 2017 · 5 comments
Assignees
Labels
Enhancement 🍭 Something existing, but better ;)

Comments

@timcosta
Copy link

timcosta commented Oct 24, 2017

Overview

If you are not aware yet, Hapi v17 is making the transition from callbacks to async/await, as well as deprecating some other rarely used functionality. This is a breaking change that may make your plugin no longer compatible with the Hapi API.

Changelog

Draft release notes can be found here: hapijs/hapi#3658

Target Release

The target release date for v17 is the beginning of November.

Tasks

  • Reply to this to acknowledge that you are actively maintaining this module and are willing to update it
  • Update plugin to be fully async/await compatible using the v17 branch from Hapi for testing

    Possible dev flow for updating

    • Clone Hapi
    • npm link within the Hapi repo
    • npm link hapi within your plugin repo
    • Your plugin will now be using v17 of Hapi branch for tests
  • Release new major version of your plugin on npm. Please use a major version increment as this will be a breaking change and it would be terrible for it to sneak into current versions of Hapi.

Notes

  • Support is being dropped for all versions of Node <8.0.0.
  • Hapi v16 will continue to be supported for as long as there exists a Node LTS actively being supported that is not compatible with v17.
  • Targeted release date is November 1st, 2017. Please try to have your plugin updated before then.
@AdrieanKhisbe
Copy link
Owner

Thanks for the heads up @timcosta
Is it possible to craft a register plugin that is compatible with both hapi?

I'm in between of major refactor (along with major feature hadding), that I intended to ship with pre hapi17. That would enable me to postpone a major bump, since I'm still not in v1.

Thanks in advance for your answer

@AdrieanKhisbe AdrieanKhisbe self-assigned this Oct 28, 2017
@AdrieanKhisbe
Copy link
Owner

@timcosta ?

Is it possible to craft a register plugin that is compatible with both hapi?

@AdrieanKhisbe
Copy link
Owner

@timcosta up :)

@AdrieanKhisbe
Copy link
Owner

A hapi17 compatible plugin is now available in the beta release of the 1.0 version.

cc @timcosta

@AdrieanKhisbe
Copy link
Owner

[email protected] was just release. closing

@AdrieanKhisbe AdrieanKhisbe added the Enhancement 🍭 Something existing, but better ;) label Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🍭 Something existing, but better ;)
Projects
None yet
Development

No branches or pull requests

2 participants