-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FCP XML adapter: AttributeError: 'NoneType' object has no attribute find / split #1661
Comments
Thank you @reinecke for handling this. I need to deal with the files from Final Cut Pro in the next couple months. Do you think it likely to have a fix for this issue in that timeframe or should I keep trying to "monkey-patch" the source code to work around these errors? |
I took a run at digging into this issue today - digging into the adapter, it looks as if the adapter has some problematic time math at a pretty deep level. Some issues I see are:
I don't have a lot of exposure to fcpxml in my pipelines so I don't think I'm the right person to take this work on as I wouldn't be able to validate my results very well. If someone else is interested in taking this on, I'd be happy to share some direction and code about what needs to be done. Also, of note, any of this work should take place over at the broken out adapter repo. |
To provide more guidance into the type of refactoring that needs to be done, I pushed a branch in my fork of the adapter repo. I was working as quickly as possible to see if I could address the issue, so I didn't do a detailed analysis to ensure correctness ot the changes I started applying. I got as far as reaching a new exception with the sample EDL that @miguelmorin provided:
I'm not so familiar with FCP X XML, so I don't really know the correct way to address this. Someone with more FCP X XML experience can maybe pick up my branch and run with it? |
I believe the original author of this adapter is @eric-with-a-c. Perhaps he can shed some light on this? I don't know exactly how it happened, but he seems to have fallen out of the contributors list when we transferred the adapter to the new repo. Sorry about that @eric-with-a-c ! |
In addition to the time math issues @reinecke mentions above, the fcpxml adapter only supports fcpxmls up to version 1.8. The current version of fcpxml exported by Final Cut Pro X by default is 1.11, with the option of exporting a 1.10 version. There were some big changes introduced in 1.9 or 1.10. For example, the whole It's probably fair to say, given the time math issues and the old fcpxml version support, the adapter needs a fair bit of work to be usable with a current project. I had started that work a while ago, but never had the time to finish. |
Thank you @reinecke , @apetrynet and @eric-with-a-c for trying to solve this problem. It seems to have very high cost-benefit ratio, given the bugs you already found and the issues from version 1.8 and 1.11, and how few people seem to need this adapter. In the meantime, I'll cut this Gordian knot by running Final Cut Pro, exporting all the assets I need (e.g., a video without titles nor captions, an audio track with only sound effects), and reassembling them inside Kdenlive. I'll keep the source files in case some brave soul in the future is able to fix this, and I can run the tests on my projects (about one hour worth of projects in Final Cut Pro, and another in Adobre Premiere Pro that I can convert via Final Cut Pro). |
Bug Report
Incorrect Functionality and General Questions
I have video projects that I want to convert from Final Cut Pro to KdenLive. I found the OpenTimelineIO project and it would solve all my problems. I installed with
I tried the sample code provided:
and get the error:
I asked on StackOverflow and replaced the offending lines:
with:
It fixes that error and processes several clips, but then I get a similar error:
To Reproduce
Expected Behavior
I expected the Python code to process the FCP XML file without errors.
Logs
For the first error, here is the console log:
For the second error, after monkey-patching around line 998, here is the console log:
Additional Context
You can find here a link to a complete FCP XML file that causes this error in order to reproduce it.
The text was updated successfully, but these errors were encountered: