Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Cookie Response for Abandon Auth Logins #135

Closed
fisher60 opened this issue Jun 19, 2024 · 0 comments · Fixed by #145
Closed

Refactor Cookie Response for Abandon Auth Logins #135

fisher60 opened this issue Jun 19, 2024 · 0 comments · Fixed by #145
Assignees
Labels
backend Relates to backend enhancement New feature or request

Comments

@fisher60
Copy link
Member

fisher60 commented Jun 19, 2024

Summary

We are using an insecure cookie policy that is setting cookies for the entire abandontech domain. Instead, we should only set cookies for the domain that abandonauth is hosted on. This should be possible by removing any explicit domain we are setting on cookies.

We also need to ensure we are using a secure cookie policy, we should still use secure=True and httponly=True in the UI response for setting cookies. Ideally, we can remove the separate cookie logic for debug mode versus prod deploy after we remove the explicit domain.

@fisher60 fisher60 added enhancement New feature or request frontend Relates to UI/UX backend Relates to backend labels Jun 19, 2024
@fisher60 fisher60 changed the title Refactor auth flow for abandon auth Refactor Cookie Response for Abandon Auth Logins Jun 20, 2024
@fisher60 fisher60 removed the frontend Relates to UI/UX label Jun 20, 2024
@fisher60 fisher60 self-assigned this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Relates to backend enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant