Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with SFDP parsing of the Sector Map Parameter Table #12574

Closed
Tracked by #14967
miteshdedhia7 opened this issue Mar 4, 2020 · 9 comments · Fixed by #14989
Closed
Tracked by #14967

Issue with SFDP parsing of the Sector Map Parameter Table #12574

miteshdedhia7 opened this issue Mar 4, 2020 · 9 comments · Fixed by #14989

Comments

@miteshdedhia7
Copy link

miteshdedhia7 commented Mar 4, 2020

Description of defect

The QSPIFBlockDevice and potentially the SPIFBlockDevice implementation has the following issue,
Spec Link: JESD216

BUG/ENHANCEMENT: The _sfdp_parse_sector_map_table() function currently only supports a single map descriptor (no commands) that may not be valid/generic implementation that will work for all flash devices. The spec specifies that there can be variable number of configuration detection commands, configurations and regions.
Spec Reference: JESD216 pg 53 section 6.5

Target(s) affected by this defect ?

CYW9P62S1_43012EVB_01 (Potentially other targets)

Toolchain(s) (name and version) displaying this defect ?

Toolchain: All toolchains

What version of Mbed-os are you using (tag or sha) ?

fe12608

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

mbed-cli 1.10.2

How is this defect reproduced ?

Related to issue #11722

@adbridge
Copy link
Contributor

adbridge commented Mar 5, 2020

@miteshdedhia7 Thanks for providing the version for mbed-os, unfortunately that version just specifies that master is being used but doesn't narrow down a specific point. If you are indeed using master could you please instead provide a sha ?

@miteshdedhia7
Copy link
Author

miteshdedhia7 commented Mar 6, 2020

Hi Anna, Ive updated the comment with the sha that the issue was identified at. This was originally part of #11722 but there was a request to pull these out into separate issues hence submitting this issues.

@adbridge
Copy link
Contributor

adbridge commented Mar 9, 2020

Hi Anna, Ive updated the comment with the sha that the issue was identified at. This was originally part of #11722 but there was a request to pull these out into separate issues hence submitting this issues.

@miteshdedhia7 It doesn't look like you added the sha to the correct field:
What version of Mbed-os are you using (tag or sha) ?
mbed-os-99.99.99

Thanks

@ciarmcom
Copy link
Member

ciarmcom commented Mar 9, 2020

@miteshdedhia7 thank you for the update.It appears however that there is still some missing information:

Have you correctly specified which version of Mbed OS you are using (tag or sha)? We cannot automatically identify a release based on what you have provided.

NOTE: If there are fields which are not applicable then please just add 'n/a' or 'None'.This indicates to us that at least all the fields have been considered.

@miteshdedhia7
Copy link
Author

Hi Anna, Ive updated the comment with the sha that the issue was identified at. This was originally part of #11722 but there was a request to pull these out into separate issues hence submitting this issues.

@miteshdedhia7 It doesn't look like you added the sha to the correct field:
What version of Mbed-os are you using (tag or sha) ?
mbed-os-99.99.99

Thanks

@adbridge I tried updating just the sha but I still keep getting emails that it was not able to parse the sha hence moved it out into the description section and kept the tag/sha field as master. May be the format wasn't correct? Ive updated it again with just the SHA hopefully this works.

@adbridge
Copy link
Contributor

@miteshdedhia7 Thanks, whatever you did has fixed it :)

@ciarmcom
Copy link
Member

ciarmcom commented Oct 2, 2020

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers.
Internal Jira reference: https://jira.arm.com/browse/IOTOSM-2273

@ARMmbed ARMmbed deleted a comment from ciarmcom Oct 6, 2020
@amartsan
Copy link

amartsan commented Dec 2, 2020

Hi,

CYW9P62S1-43012EVB-01 target hardware is using serial flash part number S25FS512S.
https://www.cypress.com/file/216376/download

If I check data sheet for this part, the configuration detect commands are

CR3NV[3] - Bit 3 of CR3NV - Default value 0
CR1NV[2] - Bit 2 of CR1NV - Default value 0
CR3NV[1] - Bit 1 of CR3NV - Default value 0

Since default state of these register values are 0 and the constructed configuration index will also be 0.
However, configuration ID's available in SFDP table are only 01, 03, 05 for this serial flash part and hence SMIF driver cannot find a matching configuration index to populate region information.

Regards,
Sandeep

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 26, 2021

Thanks @amartsan for looking at this issue.

However, configuration ID's available in SFDP table are only 01, 03, 05 for this serial flash part and hence SMIF driver cannot find a matching configuration index to populate region information.

Is there anything to fix here or what is the action to resolve this issue?

@Patater Patater added this to Inbox in Mbed Core via automation Jul 26, 2021
@Patater Patater moved this from Inbox to To do (16) in Mbed Core Jul 26, 2021
@Patater Patater added this to Open in Issue Workflow Jul 26, 2021
@Patater Patater moved this from Untriaged to Critical in Issue Severity Jul 26, 2021
@LDong-Arm LDong-Arm self-assigned this Aug 2, 2021
@LDong-Arm LDong-Arm moved this from To do (16) to In progress (8) in Mbed Core Aug 3, 2021
@LDong-Arm LDong-Arm moved this from In progress (8) to Awaiting review (3) in Mbed Core Sep 8, 2021
@LDong-Arm LDong-Arm moved this from Awaiting review (3) to Review in progress (4) in Mbed Core Sep 9, 2021
@LDong-Arm LDong-Arm moved this from Review in progress (4) to Reviewer approved & awaiting CI & merge (3) in Mbed Core Sep 10, 2021
Mbed Core automation moved this from Reviewer approved & awaiting CI & merge (3) to Done Sep 13, 2021
Issue Workflow automation moved this from Open to Done Sep 13, 2021
@Patater Patater moved this from Done to Reported in Mbed Core Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mbed Core
  
Reported
Development

Successfully merging a pull request may close this issue.

8 participants