-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some instructions are missing in Readme, Can't run karma tests #50
Comments
Hmmm... Mocha and Karma are both listed in the devDependencies, so they should be installed as part of the |
They are, maybe it's a different version issue, but I had to add the
plugins to karma.conf.js, not package.json .
I will try a fresh checkout today again and confirm
Thanks
…On Sat, Oct 7, 2017, 10:25 PM James Messinger, ***@***.***> wrote:
Hmmm... Mocha and Karma are both listed in the devDependencies
<https://github.com/BigstickCarpet/json-schema-ref-parser/blob/master/package.json#L59-L69>,
so they should be installed as part of the npm install command. My guess
is that some errors occurred during the npm install, so not all
dependencies were installed correctly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABnFfYgYb4jC0Ju2lPP5Q1SMftl9KNYBks5sqDK0gaJpZM4PxjkD>
.
|
Ok, cool. I'm glad you got the tests working. The build step (which runs as part of |
Hi,
I want to potentially use this library in an enterprise environment, and having a security flag ( even on a debug library ) is not a good thing from their point of view.
So I wanted to upgrade 'debug' to ^3.1.0, and I ran into some build issues from master.
Running on:
node v6.11.3
npm v3.10.10
Missing requirements from Readme:
npm install -g karma mocha karma-cli
When running
npm test
, the karma step fails due to missing plugins.I have had to modify karma.conf.js
I have made a build that fixes those issues, I can open a PR with the changes .
I can submit another PR for debug library version change.
Cheers,
The text was updated successfully, but these errors were encountered: