Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some instructions are missing in Readme, Can't run karma tests #50

Closed
moejay opened this issue Oct 8, 2017 · 4 comments
Closed

Some instructions are missing in Readme, Can't run karma tests #50

moejay opened this issue Oct 8, 2017 · 4 comments

Comments

@moejay
Copy link

moejay commented Oct 8, 2017

Hi,
I want to potentially use this library in an enterprise environment, and having a security flag ( even on a debug library ) is not a good thing from their point of view.

So I wanted to upgrade 'debug' to ^3.1.0, and I ran into some build issues from master.

Running on:
node v6.11.3
npm v3.10.10

Missing requirements from Readme:
npm install -g karma mocha karma-cli

When running npm test, the karma step fails due to missing plugins.
I have had to modify karma.conf.js

I have made a build that fixes those issues, I can open a PR with the changes .
I can submit another PR for debug library version change.

Cheers,

@JamesMessinger
Copy link
Member

Hmmm... Mocha and Karma are both listed in the devDependencies, so they should be installed as part of the npm install command. My guess is that some errors occurred during the npm install, so not all dependencies were installed correctly.

@moejay
Copy link
Author

moejay commented Oct 8, 2017 via email

@moejay
Copy link
Author

moejay commented Oct 8, 2017

So I did some other tests, it turned out karma is running fine, but for some reason npm is exiting with error code 1 ( complaining about karma not working ) but you can see in the screenshot, the tests ran fine.
Not sure what exactly is happening :(
screen shot 2017-10-08 at 10 32 38 am

Another maybe minor issue, is that what's in master is not the final .js ( But that can be fixed after any PR merge, just thought I would point it out ) , there are some differences once I run npm test

screen shot 2017-10-08 at 10 36 51 am

Anyway, If you don't have any ideas, I will close this issue, and I will open a new one for updating the debug library.

Cheers

@JamesMessinger
Copy link
Member

Ok, cool. I'm glad you got the tests working.

The build step (which runs as part of npm test) inserts the current date into a comment at the top of the code, so it's normal for the dist files to appear to be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants