Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistencies in type definitions #224

Closed
medfreeman opened this issue Mar 23, 2021 · 1 comment · Fixed by #225
Closed

Inconsistencies in type definitions #224

medfreeman opened this issue Mar 23, 2021 · 1 comment · Fixed by #225
Labels
released

Comments

@medfreeman
Copy link
Contributor

Hi.

I encountered a few inconsistencies in included type definitions:

  • they don't support JSONSchema7, whereas the tool is draft agnostic
  • the resolve Options key doesn't pass strict mode checks, because its index signature is not compatible with the defined keys
  • the ResolverOptions interface has its read function signature return type union missing JSONSchema

I'll be submitting a PR in a few minutes!
@medfreeman medfreeman mentioned this issue Mar 23, 2021
Merged
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

🎉 This issue has been resolved in version 9.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
1 participant
@medfreeman