-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root ref fails to parse #201
Comments
@isaacl Yes I faced the same issue, it gives 'Circular $ref pointer found ...' error even though this is a valid case. |
This also fails for me but just incorrectly resolves the reference instead of failing with a circular ref pointer error. I believe that my issue is due to this check in Pointer::resolve:
This causes any reference at the top level to resolve to a pointer to the root instead of falling through to resolve the reference properly. Is this check necessary? It seems that this will prevent correct pointer resolution for any schema with a top-level reference. |
If this is still an issue please can somebody send a pull request. |
is valid (in fact is part of the test suite here). But json-schema-to-typescript fails to resolve the ref using this library.
Originally filed at bcherny/json-schema-to-typescript#349
The text was updated successfully, but these errors were encountered: