External reference cannot be referenced multiple times within the same schema

[rjfredrick]

Say I have a schema that looks like this:

"description": "some schema",
"properties": {
  "background_color": {
    "$ref": "./color.json"
  },
  "foreground_color": {
    "$ref": "./color.json"
    }
}

• background_color is resolved correctly but foreground_color is undefined due to the following:

resolve-external.js

// resolving for foreground_color ends up in the if-block, due to parse call on background_color,
// but the value is undefined

if ($ref) {
  // We've already parsed this $ref, so use the existing value
  return Promise.resolve($ref.value);
}

parse.js

// parse is called for background_color and adds the path to $refs but the value is `undefined` 
// until the promise is resolved

// Remove the URL fragment, if any
path = url.stripHash(path);

// Add a new $Ref for this file, even though we don't have the value yet.
// This ensures that we don't simultaneously read & parse the same file multiple times
let $ref = $refs._add(path);
...

const parser = await parseFile(file, options, $refs);
$ref.value = parser.result;

[rjfredrick]

I was using bundle when should have been using dereference, closing issue.