Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omitting TypedArrays from crawling? #185

Closed
ntamas opened this issue Jun 17, 2020 · 2 comments
Closed

Omitting TypedArrays from crawling? #185

ntamas opened this issue Jun 17, 2020 · 2 comments

Comments

@ntamas
Copy link
Contributor

ntamas commented Jun 17, 2020

I have recently run into an issue with json-schema-ref-parser on a JSON object that uses $ref pointers to binary assets that get merged into the JSON object as Uint8Arrays. Some of these arrays are fairly large (several megabytes), and it turns out that the crawl() function in lib/dereference.js descends into every single element of these arrays even though they cannot contain $ref references to other items (since all the elements are numbers).

Would it be possible to exclude TypedArrays from the crawl? If so, would you be open to accepting a PR if I prepare one?

@JamesMessinger
Copy link
Member

Yeah, I think that makes total sense. A PR would be appreciated 👍

@philsturgeon
Copy link
Member

Fixed in #187.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants