Resolved might be null #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
fix/nullish-resolved
branch
from
9c392ab
to
ccbd40d
Compare
philsturgeon
approved these changes
Jan 18, 2021
|
@P0lip I approved this a few months back, could you fix conflicts and merge it in when you have a moment? |
|
@philsturgeon something feels off with these checks. They don't run at all. |
|
🎉 This PR is included in version 9.0.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161.
A small oversight - $Ref.resolve may return null now, so we need to take that into account.
Depends on #167 hence leaving it in adraft state.
Last but not least - typed constructors, just in case someone decides to throw these errors in parser or resolver, etc.