-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.4.1] On browser, doesn't use the right protocol and port. #11
Comments
I created a branch on my fork https://github.com/zallek/json-schema-ref-parser/tree/bugfix/port-and-protocol-resolving But I can't create PR for your repo because I need a target branch based on v1.4.1 tag. |
This issue is fixed in newer versions of the library. Please upgrade to the latest version, which includes many critical bug fixes, as well as many new features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using this lib served on localhost, the lib doesn't fetch json urls with the right port and protocol.
Some params aren't passed to
http
module which makeshttp
lib resolve url to fetch according to current protocol and port.Replacing this block at https://github.com/BigstickCarpet/json-schema-ref-parser/blob/v1.4.1/lib/read.js#L176
by the following, solve the issue:
The text was updated successfully, but these errors were encountered: