Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading over https doesn't work #10

Closed
RomanHotsiy opened this issue Feb 8, 2016 · 4 comments
Closed

Loading over https doesn't work #10

RomanHotsiy opened this issue Feb 8, 2016 · 4 comments

Comments

@RomanHotsiy
Copy link
Contributor

https protocol is ignored and specs are always loaded over http

Check out the attached picture. Despite spec url starts from https:// Chrome Debugger Network tab says that spec was loaded over http:

http:https://i.imgur.com/42T6CLI.png

I've done some research and found out that the issue is caused by this issue: https://github.com/substack/https-browserify/issues/6

So I believe to fix this issue you just need to update browserify version to v13 in this and maybe in BigstickCarpet/simplifyify package

@JamesMessinger
Copy link
Member

👍 Thanks for the heads-up. I'll update the dependencies in the next release

@JamesMessinger
Copy link
Member

@RomanGotsiy - I just released a new version of JSON-Schema-$Ref-Parser that was built with an updated version of Browserify, which uses stream-http instead of http-browserify. So this issue should be fixed now. Can you give it a try and let me know?

I'm going to optimistically close this issue. But feel free to re-open it if it turns out that I've been too hasty :)

@RomanHotsiy
Copy link
Contributor Author

@BigstickCarpet I'm using json-schema-ref-parser only as a part of swagger-parser. But I believe that the new version of json-schema-ref-parser is not compatible with the old swagger-parser. Am I right? So I can't check it until APIDevTools/swagger-parser#30 is closed :)
But I'm sure the issue is fixed now. Thanks!

@JamesMessinger
Copy link
Member

Ah, ok. Well I've started working on a new build of Swagger Parser with the updated version of JSON Schema $Ref Parser... so expect that soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants