Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using checked operation whenever user input is handled #219

Open
commial opened this issue Aug 2, 2024 · 0 comments
Open

Consider using checked operation whenever user input is handled #219

commial opened this issue Aug 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@commial
Copy link
Contributor

commial commented Aug 2, 2024

In release build, Rust's operation are no more checked.
Some operation made in MLA depends on "user" (ie. the archive data) input. For instance, seeking in the binary or getting the footer start from the last bytes.

checked operation could be considered to early panic of raise an error if this kind of operation is made with invalid arguments.

@commial commial added the enhancement New feature or request label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant