Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enable google and twitter integration without smtp #6

Closed
alekitto opened this issue May 11, 2021 · 1 comment · Fixed by #7
Closed

Cannot enable google and twitter integration without smtp #6

alekitto opened this issue May 11, 2021 · 1 comment · Fixed by #7

Comments

@alekitto
Copy link
Contributor

Hi @8gears and thank you for your work.

While configuring google integration I found that is impossible to enable google and twitter integration if smtp.enabled is falsy. Additionally, this prevents the new pods to start as the associated keys are not found in the secret.

This is due to an incorrectly positioned end tag for this if which is closed on L69 instead of L51.

@Vad1mo
Copy link
Member

Vad1mo commented May 11, 2021

Ohh thank you for pointing that out! Can you Open up a or I'll merge that ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants