Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix: hide header and sidebar on the Export page #4146

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Conversation

katspaugh
Copy link
Member

What it solves

The Export page is the only page that will be accessible in the old app for some time.
We need to prevent navigation to any other react route from it.

How it solves it

I'm hiding all header elements except for the logo (which now links to the new app), and the contents of the sidebar.

Screenshot 2023-01-25 at 10 50 24

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 2 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4004725391

  • 1 of 8 (12.5%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 41.846%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/export/Export.tsx 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
src/routes/export/Export.tsx 1 0%
Totals Coverage Status
Change from base Build 3874020678: -0.03%
Covered Lines: 4779
Relevant Lines: 10428

💛 - Coveralls

@katspaugh katspaugh merged commit af344fe into dev Jan 25, 2023
@katspaugh katspaugh deleted the export-links branch January 25, 2023 14:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants