-
Notifications
You must be signed in to change notification settings - Fork 363
fix: Add export data button to settings page #4114
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
<Block className={classes.formContainer}> | ||
<Heading tag="h2">Export your data</Heading> | ||
<Paragraph> | ||
Download your local storage data to keep your added safes and address book entries for later reimport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Download your local storage data to keep your added safes and address book entries for later reimport. | |
Download your local storage data with your added safes and address book. You can import it on app.safe.global. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just do a simple JSON.stringify(localStorage)
?
Pull Request Test Coverage Report for Build 3429390754
💛 - Coveralls |
<Block className={classes.formContainer}> | ||
<Heading tag="h2">Export your data</Heading> | ||
<Paragraph> | ||
Download your local storage data to keep your added safes and address book entries for later reimport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Download your local storage data to keep your added safes and address book entries for later reimport. | |
Download your local data to keep your added Safes and address book entries for later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with Ivans suggestion as it also includes a reference to the new domain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still remove "storage" to be less technical and capitalise "safe", e.g. "Download your local data with your added Safes and address book. You can import it on..."
|
Although this is a simple approach, it will export a lot of unnecessary data and we'd have to parse it in
|
I think the users should be able to just take all their data out.
Not sure what you mean. As Usame said, we do the same kind of migration via an iframe. |
This can be disregarded. The Redux store uses Immutable.js for the added Safes but it looks like there is separate initiation logic outside of our "standard" persistence implementation for added Safes ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Something I realized while giving adhoc support on exporting: it’s not easy to link to a safe-specific route. |
An |
What it solves
Part of safe-global/safe-wallet-web#1097
How this PR fixes it
/export
that contains the same button.json
file is versioned with version1.0
and contains adata
key with thelocalStorage
dataHow to test it
.json
file being downloaded that contains the localStorageScreenshots