Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

fix: Display claiming app at the first position in dashboard #4078

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

usame-algan
Copy link
Member

What it solves

Displays the safe-claiming-app at the first spot on the dashboard.

How to test it

  1. Open the Safe on Rinkeby
  2. Navigate to the dashboard
  3. Observe the safe-claiming-app at the top of the list

Screenshots

Screenshot 2022-09-23 at 11 01 34

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3111561560

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 42.068%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/AppLayout/Header/components/SafeTokenWidget/index.tsx 0 1 0.0%
src/components/Dashboard/SafeApps/index.tsx 0 5 0.0%
Totals Coverage Status
Change from base Build 3088946525: -0.01%
Covered Lines: 4774
Relevant Lines: 10361

💛 - Coveralls

@github-actions
Copy link

Deployment links

Mainnet     🟣 Polygon     🟠 Rinkeby

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooo!

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@francovenica
Copy link
Contributor

Looks good.
The app is always first
Pinned apps don't overtake its place
Apps with more visits don't overtake its place

@usame-algan usame-algan merged commit 69d1cfe into dev Sep 23, 2022
@usame-algan usame-algan deleted the dashboard-claiming-app branch September 23, 2022 12:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants