-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow closing the connection/session #278
Comments
@FRosner with the latest release, you can pass a custom session to |
@4n4nd thanks! I guess it still leaves it to us to close the session, but it's for sure better than accessing the private variable. Do you think there's value in providing a close method that closes the session (may it be provided or not), and maybe even the context manager methods? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
We can open a client, but we cannot close the session. We have to work around it providing our own context manager which accesses a private variable in
PrometheusConnect
:Describe the solution you'd like
Would be nice to have a close method, or even also implement context manager.
Describe alternatives you've considered
Not sure if there are any. We need to be able to not leak connections.
The text was updated successfully, but these errors were encountered: