Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of NaN values in metric aggregations #264

Open
GPalaciosFdez opened this issue Jun 8, 2023 · 1 comment
Open

Handling of NaN values in metric aggregations #264

GPalaciosFdez opened this issue Jun 8, 2023 · 1 comment
Assignees

Comments

@GPalaciosFdez
Copy link

Describe the bug
Not really sure if a bug or a design decision but I could not find this case covered in the tests.

When using numpy to calculate the different operations in get_metric_aggregation the functions chosen will return NaN if there is a value in the metric that is NaN.

For example for:

To Reproduce
Steps to reproduce the behavior:

  1. Pass a metric with a NaN value and several numerical values to get_metric_aggregation
  2. Check the result and you should see that it is NaN

Expected behavior
Handle NaN values to return a statistically meaningful number

Additional context
I could submit a PR if you think this is something that can be changed.
It could even be possible to pass a boolean flag handle_nans as an argument to get_metric_aggregation to choose the behavior.

@GPalaciosFdez
Copy link
Author

Hi :)

Any comments about this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants