Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add controls to subplot() #252

Open
mahtin opened this issue Oct 30, 2022 · 2 comments
Open

add controls to subplot() #252

mahtin opened this issue Oct 30, 2022 · 2 comments
Labels
good first issue Good for newcomers hacktoberfest Issues targeting the hacktoberfest participants.

Comments

@mahtin
Copy link
Contributor

mahtin commented Oct 30, 2022

Is your feature request related to a problem? Please describe.

No - not a problem. It's an honest-to-gosh simple request to make life easier.

When you call plot() you create a new window. Two calls, two windows created. If you could pass subplot() arguments to the underlying subplot() call, then you could control the layout with minimal extra code.

Describe the solution you'd like

Add **kwargs to plot() call such that subplot() can be controlled. I believe the following simple edit would work:

def plot(self, **kwargs):
    ...
    fig, axis = plt.subplots(**kwargs)
    ...

Describe alternatives you've considered

While it's very easy to loop and call subplot() myself, I feel that the cool way plot() was implemented should be retained; but with these added controls.

@4n4nd
Copy link
Owner

4n4nd commented Oct 31, 2022

@mahtin that seems like a reasonable solution. Would you please make the changes and create a pull request for it?

Thanks!

@4n4nd 4n4nd added good first issue Good for newcomers hacktoberfest Issues targeting the hacktoberfest participants. labels Oct 31, 2022
@mahtin
Copy link
Contributor Author

mahtin commented Nov 1, 2022

Would you ...

Yes. Done. See #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Issues targeting the hacktoberfest participants.
Projects
None yet
Development

No branches or pull requests

2 participants