Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v3 & v5 generation #606

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Fix v3 & v5 generation #606

merged 2 commits into from
Oct 18, 2022

Conversation

gutiory
Copy link
Contributor

@gutiory gutiory commented Oct 18, 2022

💭 Why this change?

An issue has been detected for v3 and v5 UUID generation. Ref #605

🚀 What has been changed in this PR?

  • Fix for v3 and v5 generation
  • Added 2 test cases
  • Run scalafmt

@gutiory gutiory changed the title Fix v3 & v5 hashing Fix v3 & v5 generation Oct 18, 2022
@gutiory gutiory added the bug Something isn't working label Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #606 (164452d) into main (b86738f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          14       14           
  Lines          87       87           
  Branches        6        6           
=======================================
  Hits           86       86           
  Misses          1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cb372
Copy link
Member

cb372 commented Oct 18, 2022

It's a bit hard to review this because the switch from spaces to tabs has resulted in a large diff. Was that intentional?

@gutiory
Copy link
Contributor Author

gutiory commented Oct 18, 2022

It's a bit hard to review this because the switch from spaces to tabs has resulted in a large diff. Was that intentional?

I just run the scalafmt and add the changes in the last commit. The actual changes are in the first one 1d746c8 (#606)

@cb372
Copy link
Member

cb372 commented Oct 18, 2022

Actually it looks like before your changes UUID.java was a mix of spaces and tabs 😱

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gutiory gutiory merged commit 54a5990 into main Oct 18, 2022
@gutiory gutiory deleted the fix/v3-v5-generation branch October 18, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants