Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration module with Tapir #233

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Conversation

alejandrohdezma
Copy link
Collaborator

From its own website...

With tapir you can describe HTTP API endpoints as immutable Scala values. Each endpoint can contain a number of input parameters, error-output parameters, and normal-output parameters

This new module adds a bunch of implicit instances to allow using memeid's UUID as path/query params or headers values, as well as enriching auto-generated documentation for UUID fields.

@github-actions github-actions bot added the enhancement New feature or request label Sep 16, 2020
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #233 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   98.71%   98.76%   +0.04%     
==========================================
  Files          11       12       +1     
  Lines          78       81       +3     
  Branches        1        1              
==========================================
+ Hits           77       80       +3     
  Misses          1        1              
Impacted Files Coverage Δ
...apir/src/main/scala/memeid4s/tapir/instances.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a232bc...daa7bca. Read the comment docs.

project/dependencies.scala Show resolved Hide resolved
project/dependencies.scala Show resolved Hide resolved
Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alejandrohdezma alejandrohdezma merged commit 6490a2e into master Sep 17, 2020
@alejandrohdezma alejandrohdezma deleted the feature/tapir-integration branch September 17, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants