Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0.0] Unwanted "print" in ForexDataClient #7

Open
MichalMES opened this issue Jun 9, 2020 · 0 comments
Open

[6.0.0] Unwanted "print" in ForexDataClient #7

MichalMES opened this issue Jun 9, 2020 · 0 comments

Comments

@MichalMES
Copy link

MichalMES commented Jun 9, 2020

Hello,

Our company just met an issue with your newest v6.0.0 library.
There is a redundant print used in getQuotes() method. This resulted in malformed API response in our application. (debugging-relic perhaps?)

print("Here pairs". strlen($pairs));

Our walk-around for this bug was to cut off buffered output:

ob_start(); 
$result = $client->getQuotes(); 
ob_end_clean();

... but it is kind of dirty way. We hope that you could clean it up so we all can have a little more pretty code. :-)

Thanks in advance!
Kind regards,
Mike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant