Add GitHub Actions to build and add release asset #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: * Had to ensure application-passwords was included * The copy task suddenly started complaining about async so I used the callback function method to fix * Enables updating from release assets, meaning that this won't actually show meaningful download stats until the next release * I have no idea if this is going to work on GH but the commands do work correctly locally
|
This looks good to me, assuming we've got |
|
@jeffpaul |
|
@helen I realize that we still have some vendor packages under version control. We can remove them completely and use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds GitHub Actions to build the release and create and attach a ZIP file to the GitHub release for download metric tracking. Note that download metrics will only come into play beginning with the release following this one, because this PR also enables updating from release assets.
Because the build component is automated now, the POT file has been removed in favor of generating it and only having it in the
stablebranch. One thing I noticed is that the POT file includes strings from the vendor folder; I am not sure how to get around that, but if we can somehow ignore those when generating the POT, we should probably do that.Alternate Designs
Leaving as-is, very manual and error-prone.
Benefits
Less human error!
Possible Drawbacks
I won't really know if this works until it runs live.
Verification Process
See above. I did run various individual steps locally and they do work.
Checklist:
Applicable Issues
Fixes #600 and #425
Changelog Entry
Needs