Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External connections page markup enhancements - #550 #576

Merged

Conversation

joshuaabenazer
Copy link
Contributor

Takes care of #550

Description of the Change

  1. Attempt to make markup more consistent with that of default post type listing pages
  2. "Add new" is now not part of the title “External connections” and is outside the H1.
  3. "<h2 class="screen-reader-text">Filter connections list</h2>" added before filters list.
  4. "All" filter is now highlighted

Benefits

Takes care of some issues with accessibility and also keeps a consistent default look for the post type listings across the dashboard

Verification Process

  1. Head over to Dashboard -> Distributor -> External connections
  2. Compare header and filters markup with that on page wp-admin/edit.php?post_type=dt_ext_connection

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#550

Changelog Entry

  • Fixed - External connections page markup enhancements

@jeffpaul jeffpaul requested a review from dinhtungdu April 2, 2020 19:30
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Apr 2, 2020
@jeffpaul jeffpaul added this to the 1.6.0 milestone Jun 11, 2020
@jeffpaul
Copy link
Member

jeffpaul commented Jul 2, 2020

This has been tested locally and confirmed passing tests, current check is failing as PR author doesn't have write access to the repo.

@jeffpaul jeffpaul merged commit 30222b7 into 10up:develop Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants