-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributor admin bar menu unavailable in Gutenberg fullscreen mode (current WP default) #597
Comments
While we work to determine how best to resolve this issue, I'm going to push up a PR to add a caveat to our readme and alert Distributor users to disable fullscreen editing to ensure they have access to the admin bar. |
This was annoying me as well. Totally ridiculous that they didn't add a switch to disable it in the settings. |
@Siedlerchr thanks for sharing, though right now I don't want to force block fullscreen mode in Distributor so much as alert the Distributor community that it needs to be disabled to view the Distributor push menu in the admin bar. Glad to see you've found a workaround that best fits your usage! |
Some additional input on folks running into this issue lately, possible option to consider:
We'll want to see if the Gutenberg setting for fullscreen mode is targetable to then display a warning in the admin, as otherwise we'd be showing the warning to everyone who may not need to worry about this issue (e.g., they use classic editor, they work with fullscreen mode disabled). |
Describe the bug
In testing something unrelated, I noticed that WP 5.4 and the new default of fullscreen mode for Gutenberg that post-publish you don’t get the admin bar anymore so the Distributor menu is no longer visible in Gutenberg when it used to be.
Steps to Reproduce
Expected behavior
I know we want to avoid cluttering up the sidebar with more cognitive load and maintaining 2 UIs, so some options to consider are:
Screenshots
Environment information
Additional context
Back in August 2019 a Gutenberg issue was opened looking to add a SlotFill to the Toolbar in the Gutenberg header. Later that month our very own @ryanwelcher pushed up a PR to try and solve that issue, but it appears the Gutenberg team either doesn't appreciate the issue at hand or don't agree with the approach of the PR as there's no clear direction from that team on how to resolve the linked issue (either by iterating on the PR or via a completely separate approach).
Then in April of this year, a similar issue was opened which then referenced back to the earlier issue and PR from August 2019. Then again in May of this year, a related issue was opened focused more on missing the New/View Page options from the adminbar.
In reviewing Gutenberg PRs to see what other options may currently be explored to adjust the fullscreen mode all that seems to exist is a merged (and then reverted) PR from March of this year that attempted to make the WP logo toggle the WP Admin sidebar view on/off from fullscreen mode. A second PR attempt on this WP logo toggle from May of this year is still open and appears on hold and unlikely to be merged in time to make it into WP 5.5.
The text was updated successfully, but these errors were encountered: