Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad links pointing to filter/hooks in README.md #461

Closed
dmchale opened this issue Oct 2, 2019 · 1 comment
Closed

Bad links pointing to filter/hooks in README.md #461

dmchale opened this issue Oct 2, 2019 · 1 comment
Assignees
@dmchale
Labels
needs:documentation This requires documentation. type:enhancement New feature or request.
Milestone
1.6.0

Comments

@dmchale
Copy link
Contributor

dmchale commented Oct 2, 2019

PR will follow this post, but per the contributing guidelines wanted to create an Issue first and make sure there was something to reference.

Three links send the reader to "here" without referencing what the name of the filter or hook is, which is confusing since the links have become stale and do not point to the correct line numbers in their files anymore.

I propose fixing the current links to the current line numbers, and adding the names of filters/hooks when linking to them. That way when code changes again in the future, the reader still has enough info to help themselves and find the appropriate line of code.
@dmchale dmchale added the type:enhancement New feature or request. label Oct 2, 2019
@dmchale dmchale mentioned this issue Oct 2, 2019
Merged
6 tasks
@jeffpaul jeffpaul added this to the 2.0.0 milestone Feb 5, 2020
@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Feb 5, 2020
@jeffpaul
Copy link
Member

Resolved via #462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmchale dmchale

Labels
needs:documentation This requires documentation. type:enhancement New feature or request.
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@jeffpaul @dmchale