Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove drf-addons dependency. #110

Open
sumit4613 opened this issue Sep 12, 2021 · 0 comments · May be fixed by #208
Open

Remove drf-addons dependency. #110

sumit4613 opened this issue Sep 12, 2021 · 0 comments · May be fixed by #208
Labels
enhancement good first issue Easy to fix issues

Comments

@sumit4613
Copy link
Member

sumit4613 commented Sep 12, 2021 •
edited
Loading

Describe the feature you'd like

We need to remove drf-addons dependency from this project as we're only using it's minor features only.

We will rewrite these 2 methods:

  • get_client_ip
  • send_message

And we'll remove usage of JsonResponse. Use DRF's Response or something.

Please write tests. 🙏🏼

Is your feature request related to a problem?

Your Environment

  • drf-user version(s) (drf-user --version:
  • Operating System(s):
  • Python version(s):

Additional context
@sumit4613 sumit4613 linked a pull request Oct 8, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Easy to fix issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(deps): remove drfaddons dependency 101Loop/drf-user
1 participant
@sumit4613