Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Clippy complaining that FMOptions isn't camel case. #28

Merged
merged 1 commit into from
May 6, 2021

Conversation

ltratt
Copy link
Member

@ltratt ltratt commented May 3, 2021

No description provided.

@vext01
Copy link
Member

vext01 commented May 4, 2021

Are you happy to apply that rule to the whole module, or did you only want it on that one struct?

@ltratt
Copy link
Member Author

ltratt commented May 4, 2021

I think the lint is asinine, so I'm happy to apply it globally.

@vext01
Copy link
Member

vext01 commented May 4, 2021

I'm not sure if that annotation is global or just the module, but I'll leave that up to you to look into.

bors r+

bors bot added a commit that referenced this pull request May 4, 2021
28: Stop Clippy complaining that FMOptions isn't camel case. r=vext01 a=ltratt



Co-authored-by: Laurence Tratt <[email protected]>
@ltratt
Copy link
Member Author

ltratt commented May 4, 2021

It's global to the crate.

@bors
Copy link
Contributor

bors bot commented May 4, 2021

Build failed:

@vext01
Copy link
Member

vext01 commented May 4, 2021

Needs rustfmt

@vext01
Copy link
Member

vext01 commented May 6, 2021

Don't forget this PR :)

@ltratt
Copy link
Member Author

ltratt commented May 6, 2021

Oops! Fixed in 13c159d.

@vext01
Copy link
Member

vext01 commented May 6, 2021

Please squash.

@ltratt
Copy link
Member Author

ltratt commented May 6, 2021

Squashed.

@vext01
Copy link
Member

vext01 commented May 6, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented May 6, 2021

Build succeeded:

@bors bors bot merged commit 068ac86 into softdevteam:master May 6, 2021
@ltratt ltratt deleted the acronyms branch May 18, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants