Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gitignore generated intl #253

Closed
wants to merge 3 commits into from

Conversation

kackogut
Copy link
Collaborator

Description

Update Read.me with info about translations
Remove generated translations files

Checklist:

Creator

  • The target branch is main
  • I have updated the unreleased section of the change log
  • I have reviewed the 'files changed' tab on github to ensure all changes are as expected
  • I have added someone to review the pr

Reviewer

  • I have verified the above are all completed
  • I have run the code locally to ensure it fufills the requirements of the issue
  • I have reviewed the 'files changed' and commented on any sections which I think are not needed, incorrect or could be improved

After pull

  • If appropriate I have closed the issue/ moved the trello card

@kackogut kackogut requested a review from JElgar February 15, 2024 21:55
README.md Outdated
install translations plugin for your IDE:
- [Android Studio](https://plugins.jetbrains.com/plugin/13666-flutter-intl)
- [VSCode](https://marketplace.visualstudio.com/items?itemName=localizely.flutter-intl)
Plugin should automatically generate `messages` files inside `generated/intl` if not
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JElgar could you please check out this branch and let me know if the tranlsations works for you and don't break the build after ignoring those files? I think that without IDE you might need to generate them manually each time translations are changed 😢

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better then to keep those generated files?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does fail... Im not too worried about having build steps locally though. (We already have to build the openapi client before we can compile and I think thats a happier place than committing built artifacts). Potentially we should add some more commands to the make file to bootstrap all this stuff?

@JElgar JElgar force-pushed the main branch 2 times, most recently from 08c843d to 69da324 Compare August 11, 2024 11:10
@kackogut kackogut closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants