-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations update from Hosted Weblate #2119
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe recent updates enhance the localization of an application by adding and refining translations in Czech, German, Indonesian, Italian, Japanese, Russian, Turkish, and Simplified Chinese. New phrases improve user experience across functionalities such as media handling, segment management, and user guidance. The changes ensure that users can navigate the application more effectively, making it more accessible for speakers of these languages. Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (10)
🚧 Files skipped from review as they are similar to previous changes (9)
🔇 Additional comments (11)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- locales/ja/translation.json (1 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (1)
- locales/zh_Hans/translation.json
Additional comments not posted (57)
locales/ja/translation.json (10)
881-881
: Translation approved for "All segments match this expression."The translation "すべてのセグメントがこの式に一致。" accurately reflects the original English text.
882-882
: Translation approved for "Cut at the preceding keyframe (not accurate time.) Equiv to"The translation "直前のキーフレームで切り取り (正確な時間ではない) 以下に相当" accurately conveys the original message.
883-883
: Translation approved for "Open URL"The translation "URLを開く" is accurate and uses standard terminology.
884-884
: Translation approved for "Playback rate"The translation "再生速度" accurately represents the concept of playback speed.
885-885
: Translation approved for "Open media from URL"The translation "URLからメディアを開く" accurately conveys the intended action.
886-886
: Translation approved for "Output file name template"The translation "出力ファイル名のテンプレート" is accurate and uses standard terminology.
887-887
: Translation approved for "Advanced settings are currently not visible."The translation "現在、高度な設定を表示していません。" accurately reflects the original text.
888-888
: Translation approved for "Please select a working directory first"The translation "まず作業ディレクトリを選択します" is accurate and uses appropriate language.
889-889
: Translation approved for "Segment starts after 01:00"The translation "セグメントは 01:00 以降に開始" accurately conveys the timing information.
890-890
: Translation approved for "This gives you an overview of the export and allows you to customise more parameters before exporting, like changing the output file name."The translation "出力の概要を表示します。また出力ファイル名の変更など、出力前に多くの調整が可能です。" accurately conveys the original message.
locales/tr/translation.json (47)
832-832
: Translation Approved.The translation for "All segments match this expression." is correct and contextually appropriate.
833-833
: Translation Approved.The translation for "All tracks have been extracted." is correct and accurately conveys the intended meaning.
834-834
: Translation Approved.The translation for "At least one codec is not supported by the selected output file format. Try another output format or try to disable one or more tracks." is accurate and clearly communicates the original message.
835-835
: Translation Approved.The translation for "Create segments from subtitles." is correct and contextually appropriate.
836-836
: Translation Approved.The translation for "Cut at the preceding keyframe (not accurate time.) Equiv to" is accurate and reflects the original message.
837-837
: Translation Approved.The translation for "Downloading URL" is correct and straightforward.
838-838
: Translation Approved.The translation for "Enter JavaScript expression" is accurate and contextually appropriate.
839-839
: Translation Approved.The translation for "Examples" is correct and appropriate.
840-840
: Translation Approved.The translation for "Expression failed: {{errorMessage}}" is correct and maintains the placeholder for the error message.
841-841
: Translation Approved.The translation for "Failed to extract frames" is accurate and conveys the intended meaning.
842-842
: Translation Approved.The translation for "GPS track" is correct and appropriate for the context.
843-843
: Translation Approved.The translation for "kbit/s" is correct and uses the appropriate abbreviation for seconds in Turkish.
844-844
: Translation Approved.The translation for "More settings" is accurate and contextually appropriate.
845-845
: Translation Approved.The translation for "Mute preview" is correct and conveys the intended action.
846-846
: Translation Approved.The translation for "Open URL" is accurate and straightforward.
847-847
: Translation Approved.The translation for "Output file name template" is correct and contextually appropriate.
848-848
: Translation Approved.The translation for "Playback rate" is accurate and conveys the intended meaning.
849-849
: Translation Approved.The translation for "Please enter a JavaScript expression." is correct and maintains the polite request form.
850-850
: Translation Approved.The translation for "Please select a working directory first" is accurate and contextually appropriate.
851-851
: Translation Approved.The translation for "Segment label (exact)" is correct and contextually appropriate.
852-852
: Translation Approved.The translation for "Segment label (regexp)" is accurate and contextually appropriate.
853-853
: Translation Approved.The translation for "Segment starts after 01:00" is correct and conveys the intended meaning.
854-854
: Translation Approved.The translation for "Segment tag value" is accurate and contextually appropriate.
855-855
: Translation Approved.The translation for "Select segments by expression" is correct and conveys the intended action.
856-856
: Translation Approved.The translation for "Use + and - for relative seek" is accurate and contextually appropriate.
857-857
: Translation Approved.The translation for "Advanced settings are currently not visible." is correct and conveys the intended meaning.
858-858
: Translation Approved.The translation for "Enter a JavaScript expression which will be evaluated for each segment. Segments for which the expression evaluates to 'true' will be selected. <1>View available syntax.</1>" is accurate and maintains the original structure and meaning.
859-859
: Translation Approved.The translation for "Export finished" is correct and contextually appropriate.
860-860
: Translation Approved.The translation for "Failed to export" is accurate and conveys the intended meaning.
861-861
: Translation Approved.The translation for "Failed to extract tracks" is correct and contextually appropriate.
862-862
: Translation Approved.The translation for "Failed to merge" is accurate and conveys the intended meaning.
863-863
: Translation Approved.The translation for "Focus segment at cursor" is correct and contextually appropriate.
864-864
: Translation Approved.The translation for "Frames have been extracted" is accurate and conveys the intended meaning.
865-865
: Translation Approved.The translation for the lengthy instruction about downloading media files is accurate and maintains the original structure and meaning.
866-866
: Translation Approved.The translation for "No segments match this expression." is correct and contextually appropriate.
867-867
: Translation Approved.The translation for "Merge finished" is accurate and conveys the intended meaning.
868-868
: Translation Approved.The translation for "Open folder" is correct and straightforward.
869-869
: Translation Approved.The translation for "Open media from URL" is accurate and contextually appropriate.
870-870
: Translation Approved.The translation for "Segment duration less than 5 seconds" is correct and conveys the intended meaning.
871-871
: Translation Approved.The translation for the segment mode description is correct and preserves the original meaning and structure.
872-872
: Translation Approved.The translation for the segment mode description is correct and preserves the original meaning and structure.
873-873
: Translation Approved.The translation for "Show GPS map" is accurate and contextually appropriate.
874-874
: Translation Approved.The translation for "Show notifications" is correct and conveys the intended action.
875-875
: Translation Approved.The translation for "Show informational in-app notifications" is accurate and contextually appropriate.
876-876
: Translation Approved.The translation for the overview of export customization is correct and contextually appropriate.
877-877
: Translation Approved.The translation for "Smart cut auto detect bitrate" is accurate and conveys the intended meaning.
878-878
: Translation Approved.The translation for the guidance on seeking help and reporting bugs is correct and contextually appropriate.
cfa3de2
to
1861641
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (2 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (1)
- locales/tr/translation.json
Files skipped from review as they are similar to previous changes (2)
- locales/ja/translation.json
- locales/zh_Hans/translation.json
Additional comments not posted (12)
locales/it/translation.json (12)
853-853
: Translation is accurate.The translation for "Advanced settings are currently not visible." is correct.
854-854
: Translation is accurate.The translation for "Cut at the preceding keyframe (not accurate time.) Equiv to" is correct.
855-855
: Translation is accurate.The translation for "More settings" is correct.
856-856
: Translation is accurate.The translation for "Open media from URL" is correct.
857-857
: Translation is accurate.The translation for "Open URL" is correct.
858-858
: Translation is accurate.The translation for "Output file name template" is correct.
859-859
: Translation is accurate.The translation for "Please select a working directory first" is correct.
860-860
: Translation is accurate.The translation for "Segment mode: "{{mode1}}" will create segments bounding the silent sections. "{{mode2}}" will create segments that start/stop at the center of each silent section." is correct.
861-861
: Translation is accurate.The translation for "Segment starts after 01:00" is correct.
862-862
: Translation is accurate.The translation for "All segments match this expression." is correct.
863-863
: Translation is accurate.The translation for "Downloading URL" is correct.
864-864
: Translation is accurate.The translation for "Losslessly download a whole media file from the specified URL, mux it into an mkv file and open it in LosslessCut. This can be useful if you need to download a video from a website, e.g. a HLS streaming video. For example in Chrome you can open Developer Tools and view the network traffic, find the playlist (e.g. m3u8) and copy paste its URL here." is correct.
1861641
to
6ab7710
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (2 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (1)
- locales/it/translation.json
Files skipped from review as they are similar to previous changes (3)
- locales/ja/translation.json
- locales/tr/translation.json
- locales/zh_Hans/translation.json
6ab7710
to
98a636e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (3 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (2)
- locales/it/translation.json
- locales/tr/translation.json
Files skipped from review as they are similar to previous changes (2)
- locales/ja/translation.json
- locales/zh_Hans/translation.json
98a636e
to
424e8a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (3 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (2)
- locales/it/translation.json
- locales/tr/translation.json
Files skipped from review as they are similar to previous changes (2)
- locales/ja/translation.json
- locales/zh_Hans/translation.json
2fd40bc
to
8c21f25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (3 hunks)
- locales/ru/translation.json (1 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (1)
- locales/tr/translation.json
Files skipped from review as they are similar to previous changes (3)
- locales/it/translation.json
- locales/ja/translation.json
- locales/zh_Hans/translation.json
Additional comments not posted (15)
locales/ru/translation.json (15)
886-886
: Translation entry for "More settings"The translation for "More settings" is correctly provided as "Больше настроек".
887-887
: Translation entry for "Open media from URL"The translation for "Open media from URL" is correctly provided as "Открыть медиафайл по URL".
888-888
: Translation entry for "Open URL"The translation for "Open URL" is correctly provided as "Открыть URL".
889-889
: Translation entry for "Output file name template"The translation for "Output file name template" is correctly provided as "Шаблон имени выходного файла".
890-890
: Translation entry for "Playback rate"The translation for "Playback rate" is correctly provided as "Скорость воспроизведения".
891-891
: Translation entry for "Please select a working directory first"The translation for "Please select a working directory first" is correctly provided as "Сначала выберите рабочий каталог".
892-892
: Translation entry for segment mode descriptionThe translation for the segment mode description involving black sections is correctly provided.
893-893
: Translation entry for "Segment starts after 01:00"The translation for "Segment starts after 01:00" is correctly provided as "Сегменты начинаются после 01:00".
894-894
: Translation entry for "All segments match this expression."The translation for "All segments match this expression." is correctly provided as "Все сегменты соответствуют данному выражению."
895-895
: Translation entry for "Downloading URL"The translation for "Downloading URL" is correctly provided as "Загрузка URL".
896-896
: Translation entry for segment mode descriptionThe translation for the segment mode description involving silent sections is correctly provided.
897-897
: Translation entry for "Cut at the preceding keyframe"The translation for "Cut at the preceding keyframe" is correctly provided as "Разрезать на предыдущем ключевом кадре".
898-898
: Translation entry for media download descriptionThe translation for the media download description is correctly provided and detailed.
899-899
: Translation entry for "Advanced settings are currently not visible."The translation for "Advanced settings are currently not visible." is correctly provided as "Расширенные настройки в настоящее время не видны."
900-900
: Translation entry for export overviewThe translation for the export overview is correctly provided and detailed.
Please create a discord or telegram group for yourself. Stop chatting here. |
8c21f25
to
0273503
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- locales/cs/translation.json (8 hunks)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (3 hunks)
- locales/ru/translation.json (1 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (2)
- locales/ja/translation.json
- locales/ru/translation.json
Files skipped from review as they are similar to previous changes (3)
- locales/it/translation.json
- locales/tr/translation.json
- locales/zh_Hans/translation.json
Additional comments not posted (3)
locales/cs/translation.json (3)
76-76
: LGTM!The change from "pracovní složka" to "pracovní adresář" improves the accuracy of the term in a computing context.
The code changes are approved.
78-78
: LGTM!The change from "pracovní složka" to "pracovní adresář" improves the accuracy of the term in a computing context.
The code changes are approved.
300-300
: LGTM!The change from "do adresáře" to "k adresáři" enhances clarity in the context of write access messages.
The code changes are approved.
0273503
to
fa190d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- locales/cs/translation.json (8 hunks)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (3 hunks)
- locales/ru/translation.json (1 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (3)
- locales/it/translation.json
- locales/ru/translation.json
- locales/tr/translation.json
Files skipped from review as they are similar to previous changes (3)
- locales/cs/translation.json
- locales/ja/translation.json
- locales/zh_Hans/translation.json
fa190d5
to
5d2c0d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- locales/cs/translation.json (8 hunks)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (3 hunks)
- locales/ru/translation.json (1 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (3)
- locales/it/translation.json
- locales/ru/translation.json
- locales/tr/translation.json
Files skipped from review as they are similar to previous changes (3)
- locales/cs/translation.json
- locales/ja/translation.json
- locales/zh_Hans/translation.json
5d2c0d9
to
9666125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- locales/cs/translation.json (8 hunks)
- locales/id/translation.json (1 hunks)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (3 hunks)
- locales/ru/translation.json (1 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (2)
- locales/ru/translation.json
- locales/tr/translation.json
Files skipped from review as they are similar to previous changes (4)
- locales/cs/translation.json
- locales/it/translation.json
- locales/ja/translation.json
- locales/zh_Hans/translation.json
Additional comments not posted (6)
locales/id/translation.json (6)
3-3
: LGTM!The translation for
(detected)
is correct.
4-4
: LGTM!The translation for
{{selectedSegments}} of {{nonFilteredSegments}} segments selected
is correct.
5-5
: LGTM!The translation for
"ffmpeg" experimental flag
is correct.
6-6
: LGTM!The translation for
(data tracks such as GoPro GPS, telemetry etc. are not copied over by default because ffmpeg cannot cut them, thus they will cause the media duration to stay the same after cutting video/audio)
is correct.
7-7
: LGTM!The translation for
+{{numFrames}} frames_one
is correct.
8-8
: LGTM!The translation for
+{{numFrames}} frames_other
is correct.
@@ -1 +1,9 @@ | |||
{} | |||
{ | |||
"{{durationMsFormatted}} ms, {{frameCount}} frames": "{{durationMsFormatted}} md, {{frameCount}} bingkai", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the typo in the translation.
The translation for {{durationMsFormatted}} ms, {{frameCount}} frames
contains a typo: md
should be ms
.
Apply this diff to fix the typo:
- "{{durationMsFormatted}} md, {{frameCount}} bingkai"
+ "{{durationMsFormatted}} ms, {{frameCount}} bingkai"
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"{{durationMsFormatted}} ms, {{frameCount}} frames": "{{durationMsFormatted}} md, {{frameCount}} bingkai", | |
"{{durationMsFormatted}} ms, {{frameCount}} frames": "{{durationMsFormatted}} ms, {{frameCount}} bingkai", |
cc852bd
to
11ba539
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
locales/ja/translation.json (1)
868-868
: Translation looks good, but please translate the link texts.The overall Japanese translation looks good. However, please also translate the texts inside the <1>, <3> and <5> tags, as they are placeholders for links. For example:
"<0>LosslessCut の問題や質問があれば、最初に<1>ヘルプ</1>メニューのリンクをご覧ください。解決法がなければ、<3>GitHub のディスカッション</3>や<5>Discord</5>で質問できます。</0><1>LosslessCut のバグを見つけたと思う場合は、<1>バグ報告</1>もできます。</1>"
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- locales/cs/translation.json (8 hunks)
- locales/de/translation.json (1 hunks)
- locales/id/translation.json (1 hunks)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (3 hunks)
- locales/ru/translation.json (1 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (2)
- locales/ru/translation.json
- locales/tr/translation.json
Files skipped from review as they are similar to previous changes (4)
- locales/cs/translation.json
- locales/id/translation.json
- locales/it/translation.json
- locales/zh_Hans/translation.json
Additional comments not posted (18)
locales/ja/translation.json (9)
136-136
: LGTM!The new Japanese translation looks good.
880-880
: LGTM!The new Japanese translation looks good.
881-881
: LGTM!The new Japanese translation looks good.
882-882
: LGTM!The new Japanese translation looks good.
883-883
: LGTM!The new Japanese translation looks good.
884-884
: LGTM!The new Japanese translation looks good.
885-885
: LGTM!The new Japanese translation looks good.
886-886
: LGTM!The new Japanese translation looks good.
887-887
: LGTM!The new Japanese translation looks good.
locales/de/translation.json (9)
893-893
: LGTM!The new German translation for "Advanced settings are currently not visible." looks good.
894-894
: LGTM!The new German translation for "All segments match this expression." looks good.
895-895
: LGTM!The new German translation for "More settings" looks good.
896-896
: LGTM!The new German translation for "Open media from URL" looks good.
897-897
: LGTM!The new German translation for "Open URL" looks good.
898-898
: LGTM!The new German translation for "Output file name template" looks good.
899-899
: LGTM!The new German translation for "Playback rate" looks good.
900-900
: LGTM!The new German translation for "Please select a working directory first" looks good.
901-901
: LGTM!The new German translation for "Segment starts after 01:00" looks good.
108dc16
to
3b7710f
Compare
468d114
to
8748fe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- locales/cs/translation.json (8 hunks)
- locales/de/translation.json (1 hunks)
- locales/id/translation.json (1 hunks)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (3 hunks)
- locales/ru/translation.json (1 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (1)
- locales/ru/translation.json
Files skipped from review as they are similar to previous changes (7)
- locales/cs/translation.json
- locales/de/translation.json
- locales/id/translation.json
- locales/it/translation.json
- locales/ja/translation.json
- locales/tr/translation.json
- locales/zh_Hans/translation.json
8748fe7
to
cc0679a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
locales/ja/translation.json (1)
893-895
: Some nitpicks for improvementA few suggestions to polish the translations:
- For "Downloading URL", consider: "URLからダウンロード中"
- For the segment mode messages, the translations are a bit awkward. Consider polishing them to sound more natural, e.g.:
- "{{mode1}}は無音部分の前後でセグメントを作成し、{{mode2}}は無音部分の中心で開始/終了するセグメントを作成します。"
- "{{mode1}}は暗転部分の前後でセグメントを作成し、{{mode2}}は暗転部分の中心で開始/終了するセグメントを作成します。"
These are just nitpicks though, so feel free to ignore if you disagree!
locales/tr/translation.json (2)
835-837
: Translations look good, but please clarify "Equiv to".The new Turkish translations for creating segments from subtitles, cutting at the preceding keyframe, and downloading a URL seem accurate.
However, can you please provide more context on what "Equiv to" means at the end of the "Cut at the preceding keyframe" translation? It's unclear how that would be used without seeing the full UI.
846-850
: Translations look good, but consider reviewing "Playback rate".The new Turkish translations for muting preview, opening a URL, output file name template, playback rate, and the JavaScript expression prompt seem accurate.
One small suggestion: Consider reviewing if "Oynatım hızı" is the clearest translation for "Playback rate". It could potentially be confused with "Playback speed". But if you feel it's the best translation in context, feel free to ignore this nitpick.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- locales/cs/translation.json (8 hunks)
- locales/de/translation.json (1 hunks)
- locales/id/translation.json (1 hunks)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (3 hunks)
- locales/ru/translation.json (1 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
Files skipped from review due to trivial changes (2)
- locales/cs/translation.json
- locales/zh_Hans/translation.json
Additional comments not posted (54)
locales/id/translation.json (7)
2-2
: The typo in the translation still exists.The past review comment is still valid. The translation for
{{durationMsFormatted}} ms, {{frameCount}} frames
contains a typo:md
should bems
.
3-3
: LGTM!The code segment is approved.
4-4
: LGTM!The code segment is approved.
5-5
: LGTM!The code segment is approved.
6-6
: LGTM!The code segment is approved.
7-7
: LGTM!The code segment is approved.
8-8
: LGTM!The code segment is approved.
locales/ja/translation.json (15)
136-136
: LGTM!The Japanese translation accurately conveys the original meaning. The changes are approved.
868-870
: The past review comment about invalid HTML tags in the translation is still applicable. Please address the comment and update the translation to fix the HTML tags.
880-880
: The past review comment about the invalid timestamp in the original English message is still applicable. Please update the English message to use a valid timestamp as suggested before updating the translation.
881-881
: LGTM!The Japanese translation accurately conveys the original meaning. The changes are approved.
882-882
: LGTM!The Japanese translation accurately conveys the original meaning. The changes are approved.
883-883
: LGTM!The Japanese translation is simple and accurate. The changes are approved.
884-884
: LGTM!The Japanese translation accurately translates the term "playback rate". The changes are approved.
885-885
: LGTM!The Japanese translation accurately conveys the original meaning. The changes are approved.
886-886
: LGTM!The Japanese translation accurately conveys the original meaning. The changes are approved.
887-887
: LGTM!The Japanese translation accurately conveys the original meaning. The changes are approved.
888-888
: LGTM!The Japanese translation accurately conveys the original meaning. The changes are approved.
889-889
: LGTM!The Japanese translation matches the updated original English message with the correct timestamp. The changes are approved.
890-890
: LGTM!The Japanese translation accurately conveys the original meaning. The changes are approved.
891-891
: LGTM!The Japanese translation is simple and accurate. The changes are approved.
892-892
: LGTM!The Japanese translation accurately conveys the original meaning, providing clear instructions and examples. The changes are approved.
locales/tr/translation.json (11)
832-834
: LGTM!The new Turkish translations for matching segments with an expression and extracting tracks look good.
838-842
: Looks good!The new Turkish translations for handling JavaScript expressions and extracting frames look great. The terminology used is consistent.
843-845
: LGTM!The Turkish translations for "GPS track", "kbit/s", and "More settings" look good.
851-856
: Looks good!The new Turkish translations for selecting working directory, segment labels, selecting segments by expression, and relative seeking look great. The terminology used, such as "göreceli" for "relative seeking", makes sense in context.
857-859
: LGTM!The Turkish translations for the hidden advanced settings, JavaScript expression instructions for selecting segments, and the "View available syntax" link look good. Splitting the long instructions into two parts with the link handled via <1> tags is a nice touch.
860-864
: Looks good!The new Turkish translations for export finishing/failing, extracting tracks failing, merge failing, and focusing a segment at the cursor look great. Using "Dışa aktarma" consistently for "Export" is a good practice.
865-867
: LGTM!The Turkish translations for frames being extracted, the detailed instructions for downloading a media file from a URL, and no segments matching an expression look good. The long instructions are translated well, with terminology like "kayıpsız" correctly used for "lossless".
868-872
: Looks good!The new Turkish translations for merge finishing, opening folder/media from URL, short segment duration, and the explanation of segment modes for silent sections look great. Using "sessiz" for "silent" and clearly explaining the difference between the two silent section handling modes is well done.
873-878
: LGTM!The Turkish translations for segment mode handling black sections, showing GPS map/notifications, export overview and customization, and smart cut auto bitrate detection look good. The black section segment mode explanation is consistent with the silent section one, and "akıllı kesim" is a nice translation for "smart cut".
879-879
: Looks great!The Turkish translation for the instructions on troubleshooting issues and reporting bugs looks excellent. The structure of the original long English sentence is preserved well, with the HTML link tags handled correctly. The terminology used throughout the translation, such as "çözüm" for "resolution" and "hata" for "bug", seems fitting.
880-880
: LGTM!The Turkish translation for the instruction about handling overlapping/no-gap segments when "invert segments" mode is enabled looks great. It captures the full meaning of the original English instruction well, keeps "Yinyang" untranslated which seems appropriate, and preserves the <1>, <3> HTML tags for toggling the mode.
locales/it/translation.json (1)
Line range hint
1-867
: Translations look good, just a few notes:
- The JSON syntax looks valid, no obvious errors that would prevent parsing.
- The translations seem comprehensive, covering many strings used in the application UI.
- Special characters like quotes, newlines etc. are properly escaped in the JSON values.
- Some of the longer translations contain HTML tags like
<1>
,<3>
etc. Ensure these are intentional placeholders and being handled correctly by the code.A few other considerations while reviewing translations:
- Check for consistency in terminology, punctuation, capitalization etc. across translations.
- Ensure translations match the tone and intent of the source strings.
- Look out for strings that should NOT be translated, like placeholders, HTML, URLs etc.
- Consider the string lengths and if any truncation could occur in the UI for longer translations.
Overall the newly added Italian translations look good and ready to be merged. Just review the points mentioned above. Great work on the localization effort!
locales/ru/translation.json (11)
885-886
: LGTM!The new translation entries for "Smart cut auto detect bitrate" and "More settings" look good.
887-888
: Looks good!The new translation entries for opening media from a URL are appropriate.
889-891
: Approved.The new translations for output file name template, playback rate, and the working directory prompt look good. No issues found.
892-892
: Translation looks good!The new entry provides a clear translation for the segment mode description and correctly handles the mode name variables.
893-894
: Looks good to me!The new translations for the segment start condition and expression match message are clear and appropriate.
895-895
: Approved.The "Downloading URL" translation looks good.
896-896
: Translation looks good!The new entry provides a clear translation for the silent sections segment mode description and correctly handles the mode name variables, maintaining consistency with the similar entry for black sections.
897-897
: Looks good!The translation clearly communicates the behavior and limitations of cutting at the preceding keyframe and translates the "Equiv to" abbreviation. No issues found.
898-898
: Great addition!The new translation entry provides a detailed and clear explanation of how to use the URL download functionality, including a practical example. The translation looks accurate and helpful for users.
899-899
: Looks good!The translation for the message about hidden advanced settings is accurate and clear.
900-900
: Great explanation!The new translation entry provides a clear explanation of the export overview functionality, including the ability to customize parameters like the output file name before exporting. The translation looks good.
locales/de/translation.json (9)
893-894
: LGTM!The German translation for "Advanced settings are currently not visible." looks good.
895-895
: LGTM!The German translation for "All segments match this expression." looks good.
896-896
: LGTM!The German translation for "More settings" looks good.
897-897
: LGTM!The German translation for "Open media from URL" looks good.
898-898
: LGTM!The German translation for "Open URL" looks good.
899-899
: LGTM!The German translation for "Output file name template" looks good.
900-900
: LGTM!The German translation for "Playback rate" looks good.
901-901
: LGTM!The German translation for "Please select a working directory first" looks good.
902-902
: LGTM!The German translation for "Segment starts after 01:00" looks good.
cc0679a
to
75ccd44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- locales/cs/translation.json (8 hunks)
- locales/de/translation.json (1 hunks)
- locales/id/translation.json (1 hunks)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (3 hunks)
- locales/ru/translation.json (1 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
- locales/zh_Hant/translation.json (1 hunks)
Additional comments not posted (71)
locales/id/translation.json (7)
3-3
: Translation is accurate.The translation for "(detected)" as "(terdeteksi)" is correctly localized.
4-4
: Translation is accurate.The translation for "{{selectedSegments}} of {{nonFilteredSegments}} segments selected" as "{{selectedSegments}} dari {{nonFilteredSegments}} segmen terpilih" is correctly localized.
5-5
: Translation is accurate.The translation for ""ffmpeg" experimental flag" as ""ffmpeg" penanda eksperimental" is correctly localized.
6-6
: Translation is accurate.The translation for the handling of data tracks by ffmpeg is correctly localized and informative.
7-7
: Translation is accurate.The translation for "+{{numFrames}} frames_one" as "+{{numFrames}} bingkai" is correctly localized.
8-8
: Translation is accurate.The translation for "+{{numFrames}} frames_other" as "+{{numFrames}} bingkai" is correctly localized.
2-2
: Fix the typo in the translation.The translation for
{{durationMsFormatted}} ms, {{frameCount}} frames
contains a typo:md
should bems
.Apply this diff to fix the typo:
- "{{durationMsFormatted}} md, {{frameCount}} bingkai" + "{{durationMsFormatted}} ms, {{frameCount}} bingkai"Likely invalid or redundant comment.
locales/zh_Hant/translation.json (15)
857-857
: Translation for advanced settings visibilityThe translation provided for the message indicating that advanced settings are not visible is accurate and clear. This ensures that users understand when certain settings are not accessible.
858-858
: Detailed translation for downloading media from a URLThis translation entry provides a detailed explanation of how users can download media from a URL directly into LosslessCut and mux it into an MKV file. The translation is clear and instructive, making it accessible for users who need to perform this action.
859-859
: Translation for segment modes involving silent sectionsThe translation accurately describes the two modes of segment creation based on silent sections of the media. It is important that this translation maintains clarity as it directly affects how users will interact with the segment creation features of LosslessCut.
860-860
: Translation for export overviewThis entry explains the benefits of reviewing the export settings before finalizing the export process, including customizing parameters like the output file name. The translation is effectively communicated to the user.
861-861
: Translation for matching segments to an expressionThe translation for the feedback message about all segments matching a specific expression is concise and clear. This is crucial for users who are working with complex filtering or segment selection criteria.
862-862
: Translation for cutting at a preceding keyframeThe translation explains the concept of cutting at a keyframe that precedes the desired cut point, which is not precisely timed. It's important that this translation is accurate to prevent user confusion about the cutting behavior.
863-863
: Translation for downloading a URLThis simple translation indicates that a URL is being downloaded. It's straightforward and fits the context where it might be used within the application.
864-864
: Translation for accessing more settingsThe translation for accessing additional settings is appropriately concise and clear, guiding users to more configuration options within LosslessCut.
865-865
: Translation for opening media from a URLThis translation is crucial for users who need to open media directly from a URL, and it is clearly articulated in the translation.
866-866
: Translation for opening a URLThe translation for the action of opening a URL is straightforward and clear, which is essential for a function that might be frequently used by users who interact with online media sources.
867-867
: Translation for output file name templateThis translation is related to setting up a template for output file names, a feature that can help users organize their exported files more effectively. The translation should accurately convey the functionality to avoid user errors.
868-868
: Translation for playback rate adjustmentThe translation for adjusting the playback rate is accurate and straightforward, ensuring that users can easily understand how to control the speed of their media playback.
869-869
: Translation for selecting a working directoryThis translation instructs users to select a working directory before proceeding, which is a fundamental step for managing files within LosslessCut. The clarity of this translation is crucial for user workflow.
870-870
: Translation for segment start timeThe translation indicates the start time of a segment after a specific point, which is clear and precise. This helps users understand the timing of segments within their media.
871-871
: Translation for segment modes involving black sectionsThis translation describes segment creation modes based on black sections in the media, similar to the silent section modes. It's important for this translation to be clear to users who are utilizing these specific segmenting features.
locales/zh_Hans/translation.json (3)
625-625
: Update terminology for consistency.The term "黑场" has been updated to "黑色场景" to enhance clarity and consistency in the context of black scene detection. This change aligns with the objective to improve the comprehensibility of the user interface.
627-627
: Ensure error messages are clear and actionable.The translation for "Failed to detect black scenes" has been updated, which is crucial for informing users about the failure of a specific functionality in a clear and understandable manner.
918-932
: Review new translation entries for completeness and clarity.New translation entries have been added to enhance the localization of the application. These entries cover various functionalities such as downloading media from URLs, segment modes, and advanced settings. It's important to ensure that these translations are accurate and clear to facilitate user understanding and interaction with the application.
locales/ja/translation.json (3)
868-868
: Verify the HTML tag correction.The previous issue with HTML tags seems to have been addressed in the current translation. The tags now appear to be correctly formatted.
880-880
: Verify the timestamp correction.The previous issue with the invalid timestamp "00:60" has been corrected to "01:00" in the current translation.
882-895
: Review new translation entries.Several new translation entries have been added to enhance the application's localization. Ensure that these entries are accurate and correctly formatted. Here are a few examples:
- "Cut at the preceding keyframe (not accurate time.) Equiv to"
- "Open URL"
- "Playback rate"
- "Open media from URL"
- "Output file name template"
- "Advanced settings are currently not visible."
- "Please select a working directory first"
- "Segment starts after 01:00"
- "This gives you an overview of the export and allows you to customise more parameters before exporting, like changing the output file name."
- "More settings"
- "Losslessly download a whole media file from the specified URL, mux it into an mkv file and open it in LosslessCut. This can be useful if you need to download a video from a website, e.g. a HLS streaming video. For example in Chrome you can open Developer Tools and view the network traffic, find the playlist (e.g. m3u8) and copy paste its URL here."
- "Downloading URL"
- "Segment mode: "{{mode1}}" will create segments bounding the black sections. "{{mode2}}" will create segments that start/stop at the center of each black section."
- "Segment mode: "{{mode1}}" will create segments bounding the silent sections. "{{mode2}}" will create segments that start/stop at the center of each silent section."
These entries should be checked for consistency with the application's functionality and linguistic accuracy.
locales/tr/translation.json (1)
831-879
: Review of Translation EntriesThe translation entries provided in the JSON file are extensive and cover a wide range of functionalities within the application. Here are some specific observations and recommendations:
Consistency and Clarity: Ensure that the translations maintain consistency in terms of terminology and style across similar functionalities. For example, terms like "Export", "Cut", and "Segment" should have consistent translations throughout the document.
Technical Accuracy: Verify that the translations accurately reflect the technical operations they describe. For instance, terms related to file formats, error messages, and settings should be correctly translated to avoid confusion for the end-users.
Cultural Appropriateness: Consider the cultural context of the translations to ensure they are appropriate and respectful. This includes avoiding translations that might be misunderstood or offensive in the cultural context.
Grammar and Syntax: Check for any grammatical or syntactic errors in the translations. This includes proper use of punctuation, capitalization, and sentence structure.
Placeholder Handling: Ensure that placeholders (e.g.,
{{num}}
,{{path}}
) are correctly positioned within the translations and that they do not disrupt the flow of the text.User Interface Fit: Consider the length of the translations to ensure they fit well within the user interface without causing layout issues or truncation.
Overall, the translations should enhance the user experience by making the application more accessible to Turkish-speaking users. It is recommended to have a native speaker review the translations for nuances and context.
locales/it/translation.json (12)
853-853
: Translation for advanced settings visibilityThe translation for the message about advanced settings visibility is accurate and clear in Italian.
855-855
: Translation for additional settingsThe translation for "More settings" is correctly localized to Italian.
856-857
: Translation for media opening from URLThe translations for "Open media from URL" and "Open URL" are accurate and maintain the intended meaning.
859-859
: Translation for selecting a working directoryThe translation for "Please select a working directory first" is clear and instructive, aligning well with the action required from the user.
861-861
: Translation for segment start timeThe translation for "Segment starts after 01:00" is straightforward and correctly localized.
862-862
: Translation for matching segments expressionThe translation for "All segments match this expression." is accurate and effectively conveys the functionality in Italian.
863-864
: Translation for downloading media from URLThe translation provided for downloading media from a URL is comprehensive and informative, explaining the process in detail. This is particularly useful for users who need to understand how to use the feature.
866-866
: Translation for playback rateThe translation for "Playback rate" is correctly localized, maintaining the technical term in Italian.
867-867
: Translation for export overviewThe translation for providing an overview of the export process is well-executed, offering users the ability to customize parameters before exporting, which is crucial for user interaction.
865-865
: Translation for segment mode involving black sectionsThe translation for segment modes related to black sections is clear and descriptive, similar to the silent sections. Verify that the placeholders are correctly replaced in the application.
#!/bin/bash # Ensure that placeholders for black section segment modes are correctly replaced. grep -r "{{mode1}}" ../ grep -r "{{mode2}}" ../
858-858
: Check translation for output file name templateThe translation for "Output file name template" is accurate, but ensure that the context in which this translation is used is consistent with the functionality it describes.
#!/bin/bash # Verify the usage context of "Output file name template" in the application. grep -r "Output file name template" ../
860-860
: Translation for segment mode involving silent sectionsThe translation for segment modes related to silent sections is detailed and provides clarity on the functionality. Ensure that the placeholders
{{mode1}}
and{{mode2}}
are replaced dynamically in the application without issues.Verification successful
Placeholders for segment modes are correctly implemented
The placeholders
{{mode1}}
and{{mode2}}
are consistently used across multiple language translation files and are properly replaced with values '1' and '2' in the source code (ffmpeg-parameters.ts). This implementation ensures that the segment mode descriptions will be dynamically populated in the application as intended, supporting proper internationalization.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for proper replacement of placeholders in segment mode descriptions. grep -r "{{mode1}}" ../ grep -r "{{mode2}}" ../Length of output: 11993
locales/cs/translation.json (19)
76-76
: Translation Consistency ImprovedThe change from "Vlastní pracovní složka" to "Vlastní pracovní adresář" is consistent with other updates aiming to standardize the term for "directory" across the application. This helps in maintaining uniformity and reducing confusion for Czech users.
78-78
: Translation Consistency MaintainedThe term "Pracovní adresář" is used consistently with the previous change, ensuring that the terminology for "working directory" is uniform across the application. This is crucial for user understanding and interface consistency.
300-300
: New Translation AddedThe addition of the translation for "You have no write access to the directory of this file, please select a custom working dir" is important for functionality that involves file operations. It informs users about permission issues in a clear and localized manner.
412-412
: New Translation AddedThe translation for "Set a different Working directory" is added correctly. It's important for features that allow users to change application settings related to file storage, enhancing user flexibility and control.
653-653
: Translation Update for ClarityUpdating "File names of extracted video frames" from "Jména souborů" to "Názvy souborů" improves clarity and aligns with common terminology, making it easier for users to understand the context in which the files are used.
898-898
: Clarification in TranslationThe phrase "Cut at the preceding keyframe (not accurate time.) Equiv to" has been translated to provide clarity on the operation's accuracy related to keyframe cutting. This is crucial for users who need precise video editing capabilities.
899-899
: New Translation Added"Output file name template" has been added, which is likely related to user settings for defining how output files are named. This addition is important for customization and usability.
900-900
: New Translation Added"Playback rate" has been translated, which is essential for features that allow users to control the speed of video playback. This is a fundamental feature in video editing and playback applications.
901-901
: New Translation Added"Please select a working directory first" has been translated, which is a necessary instruction for users to ensure they set up their environment before proceeding with file operations. This helps in preventing errors related to file access and storage.
902-902
: New Translation Added"Segment starts after 01:00" has been added, providing users with specific functionality related to segment editing. This is useful for precise editing and control over video content.
903-903
: New Translation Added for Segment ModeThe translation for segment mode options provides clarity on how segments will be created in relation to silent sections of the video. This is crucial for users utilizing the application for editing purposes where silence detection is a key feature.
904-904
: New Translation Added"Downloading URL" has been translated, which is essential for features that allow users to download media directly via URLs. This is particularly useful for integrating web-based media sources.
905-905
: New Translation Added"Advanced settings are currently not visible." has been translated, providing users with information about the visibility of advanced settings. This is important for user interactions where advanced settings are involved.
906-906
: New Translation Added"Open media from URL" has been translated, which is crucial for features that allow users to open media files directly from URLs. This enhances the application's flexibility and usability.
907-907
: Detailed Description Added for FeatureThe translation provides a detailed description of how to use the feature to download and open media from a URL. This detailed guidance is crucial for users to effectively use the feature.
908-908
: New Translation Added"More settings" has been translated, which likely provides users with access to additional settings options. This is important for a comprehensive user experience where users can fine-tune their preferences.
909-909
: New Translation Added"Open URL" has been translated, which is essential for features that allow users to directly open URLs within the application. This enhances the application's connectivity and integration with web resources.
910-910
: New Translation Added for Segment ModeThe translation for segment mode options related to black sections provides users with specific functionality for handling video segments based on visual content. This is useful for targeted editing and adjustments.
911-911
: Export Overview Translation AddedThis translation gives users an overview of the export process, allowing them to customize parameters like the output file name before exporting. This is crucial for ensuring that users have control over the export process and can make necessary adjustments.
locales/ru/translation.json (1)
885-900
: Review of New TranslationsThe new translations added to the Russian locale file are generally well-formed and follow the correct JSON syntax. Here are some specific observations and recommendations:
Line 885: The translation for "Smart cut auto detect bitrate" seems to be missing. This could be an oversight or a placeholder that was not filled. Please verify if the translation is intended to be added or if this is a placeholder.
Lines 886-900: The translations for various UI elements like "More settings", "Open media from URL", etc., are provided. These translations seem appropriate and match the intended functionality described in the keys. However, it's important to ensure that the translations are consistent with the terminology used throughout the application to maintain a cohesive user experience.
Line 898: The translation provided for downloading a media file and opening it in LosslessCut is detailed and informative. It's good to see that it includes instructions on how to use browser tools to find the media URL, which can be very helpful for users.
General Consistency: Ensure that all translations maintain a consistent level of formality and technical language appropriate for the application's target audience. This includes consistent use of terms and phrases that might appear in multiple places within the app.
Overall, the translations are well-executed, but a final pass for consistency and completeness is recommended, especially to address the missing translation in line 885.
locales/de/translation.json (10)
893-893
: Translation for advanced settings visibilityThe translation for the message indicating that advanced settings are not currently visible is accurate and clear.
894-894
: Translation for segment expression matchThe translation for the message indicating that all segments match a given expression is accurate and clear.
895-895
: Translation for more settingsThe translation for "More settings" is succinct and appropriate.
896-896
: Translation for opening media from URLThe translation for the option to open media from a URL is correctly localized.
897-897
: Translation for open URLThe translation for "Open URL" is concise and correctly localized.
898-898
: Translation for output file name templateThe translation for "Output file name template" is accurate and fits the context of file handling.
899-899
: Translation for playback rateThe translation for "Playback rate" is accurate, reflecting the control over media playback speed.
900-900
: Translation for selecting a working directoryThe translation instructs the user to select a working directory first, which is a clear and necessary instruction for file operations.
901-901
: Translation for segment start timeThe translation for the message indicating when a segment starts is clear and uses proper formatting for time.
902-902
: Detailed description for lossless downloadingThe translation provides a detailed and informative description of how to losslessly download media from a URL, including practical steps using developer tools in a browser. This is particularly useful for users needing to handle streaming media.
@@ -865,7 +865,7 @@ | |||
"Open folder": "フォルダを開く", | |||
"At least one codec is not supported by the selected output file format. Try another output format or try to disable one or more tracks.": "選択した出力ファイルの形式では、1つ以上のコーデックが対応しません。別の出力形式を試すか、1つ以上のトラックを無効にしてお試しください。", | |||
"Enter JavaScript expression": "JavaScriptの式を入力", | |||
"<0>If you're having a problem or question about LosslessCut, please first check the links in the <1>Help</1> menu. If you cannot find any resolution, you may ask a question in <3>GitHub discussions</3> or on <5>Discord.</5></0><1>If you believe that you found a bug in LosslessCut, you may <1>report a bug</1>.</1>": "<0>LosslessCut の問題や質問があれば、最初に<1>ヘルプ</1>メニューのリンクをご覧ください。解決法がなければ、<3>GitHub の会話ページ</3> や <5>Discord</5>で質問できます。<0><1>LosslessCut のバグを見つけたと思う場合は、<1>バグ報告</1> もできます。", | |||
"<0>If you're having a problem or question about LosslessCut, please first check the links in the <1>Help</1> menu. If you cannot find any resolution, you may ask a question in <3>GitHub discussions</3> or on <5>Discord.</5></0><1>If you believe that you found a bug in LosslessCut, you may <1>report a bug</1>.</1>": "<0>LosslessCut の問題や質問があれば、最初に<1>ヘルプ</1>メニューのリンクをご覧ください。解決法がなければ、<3>GitHub の会話ページ</3> や <5>Discord</5>で質問できます。</0><1>LosslessCut のバグを見つけたと思う場合は、<1>バグ報告</1> もできます。</1>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the invalid HTML tags in the translation.
The HTML tags in the Japanese translation are invalid:
- The
<1>
tag is closed with</1>
but another<1>
tag is opened again without a corresponding close tag.
Update the translation to fix the HTML tags like this:
"<0>If you're having a problem or question about LosslessCut, please first check the links in the <1>Help</1> menu. If you cannot find any resolution, you may ask a question in <3>GitHub discussions</3> or on <5>Discord.</5></0><1>If you believe that you found a bug in LosslessCut, you may <1>report a bug</1>.</1>": "<0>LosslessCut の問題や質問があれば、最初に<1>ヘルプ</1>メニューのリンクをご覧ください。解決法がなければ、<3>GitHub の会話ページ</3> や <5>Discord</5>で質問できます。</0><1>LosslessCut のバグを見つけたと思う場合は、<1>バグ報告</1> もできます。</1>", | |
"<0>LosslessCut に問題や質問があれば、<1>ヘルプ</1>メニュー内のリンクを最初にご覧ください。それでも分からなければ、<3>GitHub の discussions</3> や <5>Discord</5> から質問してください。</0><1>LosslessCut のバグを発見したなら<2>バグ報告する</2>こともできます。</1>", |
@@ -877,5 +877,20 @@ | |||
"Focus segment at cursor": "再生カーソルのあるセグメントに焦点", | |||
"Segment label (exact)": "セグメントのラベル (正確に)", | |||
"Segment duration less than 5 seconds": "5秒未満のセグメント", | |||
"Segment starts after 00:60": "00:60 以降に開始するセグメント" | |||
"Segment starts after 00:60": "00:60 以降に開始するセグメント", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the invalid timestamp in the original English key.
The original English key has an invalid timestamp:
- "Segment starts after 00:60"
- Minutes in a timestamp only go from 00 to 59. "00:60" is invalid.
Update the English key to use a valid timestamp like this:
"Segment starts after 00:60": "00:60 以降に開始するセグメント", | |
"Segment starts after 01:00": "セグメントは 01:00 以降に開始", |
"Use + and - for relative seek": "Usa + e - per la ricerca relativa" | ||
"Use + and - for relative seek": "Usa + e - per la ricerca relativa", | ||
"Advanced settings are currently not visible.": "Le impostazioni avanzate non sono attualmente visibili.", | ||
"Cut at the preceding keyframe (not accurate time.) Equiv to": "Taglia al fotogramma chiave precedente (tempo non preciso). Equivale a", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check translation accuracy for keyframe cutting
The translation for the keyframe cutting setting seems to be incomplete. It should explain what "Equiv to" stands for, as this could be confusing for users.
Consider revising the translation to include a full explanation or remove the abbreviation if it's not necessary.
-"Cut at the preceding keyframe (not accurate time.) Equiv to"
+"Taglia al fotogramma chiave precedente (tempo non preciso). Equivalente a"
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"Cut at the preceding keyframe (not accurate time.) Equiv to": "Taglia al fotogramma chiave precedente (tempo non preciso). Equivale a", | |
"Cut at the preceding keyframe (not accurate time.) Equiv to": "Taglia al fotogramma chiave precedente (tempo non preciso). Equivalente a", |
8f97fb7
to
8431348
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
locales/cs/translation.json (2)
896-896
: Consider refining the translation for "relative"The current translation "Použijte + a - pro příbuzný skok" is mostly correct, but "příbuzný" (meaning "related") might not be the most accurate translation for "relative" in this context. Consider using "relativní" instead, which more accurately conveys the meaning of "relative" in terms of movement or positioning.
Suggested translation:
"Použijte + a - pro relativní skok"
898-898
: Minor grammatical correction neededThe translation is mostly correct, but there's a small grammatical issue. "na předchozím" should be "na předchozí" to agree with "snímek".
Suggested correction:
"Střih na předchozí klíčovém snímku (nepřesný čas). Odpovídá"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (9)
- locales/cs/translation.json (8 hunks)
- locales/de/translation.json (1 hunks)
- locales/id/translation.json (1 hunks)
- locales/it/translation.json (1 hunks)
- locales/ja/translation.json (3 hunks)
- locales/ru/translation.json (1 hunks)
- locales/tr/translation.json (1 hunks)
- locales/zh_Hans/translation.json (4 hunks)
- locales/zh_Hant/translation.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (8)
- locales/de/translation.json
- locales/id/translation.json
- locales/it/translation.json
- locales/ja/translation.json
- locales/ru/translation.json
- locales/tr/translation.json
- locales/zh_Hans/translation.json
- locales/zh_Hant/translation.json
🔇 Additional comments (6)
locales/cs/translation.json (6)
76-76
: LGTM: Improved translation consistencyThe change from "Vlastní pracovní složka" to "Vlastní pracovní adresář" improves consistency in the translation of "directory" throughout the application.
78-78
: LGTM: Consistent terminologyThe change from "Pracovní složka" to "Pracovní adresář" maintains consistency with the previous translation update for "directory".
897-897
: LGTM: Accurate new translationThe new translation "Všechny segmenty odpovídají tomuto výrazu." accurately conveys the meaning of "All segments match this expression."
899-910
: LGTM: Accurate new translationsThe newly added translations from "Output file name template" to "Segment mode: ..." are accurate and consistent with the existing style in the file. They correctly convey the meaning of the original English text and maintain appropriate terminology.
911-911
: LGTM: Accurate and well-structured translationThe new translation "Toto vám dává přehled nad exportem a umožňuje vám před exportem přizpůsobit další parametry, například změnit název výstupního souboru." accurately conveys the meaning of the original English text. It's well-structured and uses appropriate terminology.
Line range hint
1-911
: Overall: Good improvements to Czech localizationThe changes and additions to this file generally improve the Czech localization of the LosslessCut application. Most updates enhance consistency in terminology, particularly in the use of "adresář" for "directory". The new translations are accurate and maintain the existing style. A couple of minor suggestions were made for further refinement, but these are relatively small issues. Great work on improving the localization!
66a8995
to
5cf7ba5
Compare
Currently translated at 100.0% (743 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/zh_Hans/
Currently translated at 99.8% (742 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/tr/
Currently translated at 98.7% (734 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/ja/
Currently translated at 100.0% (743 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/it/
Currently translated at 100.0% (743 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/tr/
Currently translated at 99.0% (736 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/ja/
Currently translated at 99.5% (740 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/ja/
Currently translated at 100.0% (743 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/ru/
Currently translated at 100.0% (743 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/cs/
Currently translated at 0.4% (3 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/id/
Currently translated at 99.1% (737 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/de/
Currently translated at 99.3% (738 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/de/
Currently translated at 100.0% (743 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/zh_Hant/
Currently translated at 100.0% (743 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/sk/
Currently translated at 100.0% (743 of 743 strings) Translation: LosslessCut/LosslessCut Translate-URL: https://hosted.weblate.org/projects/losslesscut/losslesscut/it/
5cf7ba5
to
1695e74
Compare
Translations update from Hosted Weblate for LosslessCut/LosslessCut.
Current translation status:
Summary by CodeRabbit
New Features
Bug Fixes