Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minor bugs from unix.path #919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ca20110820
Copy link

Resolves minor bug seen from tests/test_unix.py under TestUnixPath.

The original implementation uses "{}/{}" which causes the bug when tested under Windows OS. I generalized it with:

os.path.join('{}', '{}')

without assuming the local machine's OS.

Changes

  • Fixed error from TestUnixPath.test_full_path method with os.path.join('{}', '{}').
  • Fixed unix.path.simplify_path.simplify_path_v1() function with posixpath.normpath() function.

fix: updated expect_path from test_full_path method in test_unix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant