Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds/csds: unskip test after ADS stream flow control changes are merged #7383

Closed
easwars opened this issue Jul 2, 2024 · 0 comments · Fixed by #7502
Closed

xds/csds: unskip test after ADS stream flow control changes are merged #7383

easwars opened this issue Jul 2, 2024 · 0 comments · Fixed by #7502
Assignees
@easwars
Labels
Type: Testing

Comments

@easwars
Copy link
Contributor

easwars commented Jul 2, 2024

In #7347, we added a t.Skip for arm64 in TestCSDS. See:

grpc-go/xds/csds/csds_e2e_test.go

Line 156 in 4e9b596

// TODO(easwars): Once https://github.com/grpc/grpc/issues/34099 is fixed

Once #7382 is fixed, we should be able to fix this test to not require a skip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@easwars easwars

Labels
Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

csds: unskip e2e test easwars/grpc-go
1 participant
@easwars