compiler alias analysis: Fix bug in status of map extracts #8686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the destructive update pass does not have any support for patching literal maps, as it can do for tuples to ensure that the term that will be destructively updated is on the heap, we must conservatively consider anything extracted from a literal map as aliased. This is not a significant limitation as tracking the alias status of individual associations of non-literal maps is currently considered non feasible.
CT Test Results 2 files 296 suites 10m 19s ⏱️ Results for commit e8f770a. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
@jhogberg, as far as I can tell this one is now merged to all of 26, 27, and master, shouldn't it be closed? |
|
It will close itself when the next 26 patch is released. :-) |
|
... turns out that it didn't get closed automatically this time. I've closed the PR manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the destructive update pass does not have any support for patching literal maps, as it can do for tuples to ensure that the term that will be destructively updated is on the heap, we must conservatively consider anything extracted from a literal map as aliased.
This is not a significant limitation as tracking the alias status of individual associations of non-literal maps is currently considered non feasible.
This bug is present in 26, 27 as well as in master. I'm not at all sure on the interrelationship between the various maint branches and the patch cannot be just merged forward. To help merging here is what applies to maint-27 and this is what should go into master.